summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorZeng Jingxiang <linuszeng@tencent.com>2022-07-28 18:12:36 +0800
committerMauro Carvalho Chehab <mchehab@kernel.org>2022-08-30 07:30:20 +0200
commitd682869daa23938b5e8919db45c4b5b227749712 (patch)
tree88e386efcfe2e515083cfd2ae1e9c11a2dcc67e2
parent2b064d91440b33fba5b452f2d1b31f13ae911d71 (diff)
downloadlinux-d682869daa23938b5e8919db45c4b5b227749712.tar.gz
linux-d682869daa23938b5e8919db45c4b5b227749712.tar.bz2
linux-d682869daa23938b5e8919db45c4b5b227749712.zip
media: tm6000: Fix unused value in vidioc_try_fmt_vid_cap()
Coverity warns of an unused value: assigned_value: Assign the value of the variable f->fmt.pix.field to field here, but that stored value is overwritten. before it can be used. 919 field = f->fmt.pix.field; 920 value_overwrite: Overwriting previous write to field with the value of V4L2_FIELD_INTERLACED. 921 field = V4L2_FIELD_INTERLACED; Fixes: ed57256f6fe8 ("[media] tm6000: fix G/TRY_FMT") Signed-off-by: Zeng Jingxiang <linuszeng@tencent.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
-rw-r--r--drivers/staging/media/deprecated/tm6000/tm6000-video.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/staging/media/deprecated/tm6000/tm6000-video.c b/drivers/staging/media/deprecated/tm6000/tm6000-video.c
index d855a19551f3..e06ed21edbdd 100644
--- a/drivers/staging/media/deprecated/tm6000/tm6000-video.c
+++ b/drivers/staging/media/deprecated/tm6000/tm6000-video.c
@@ -916,8 +916,6 @@ static int vidioc_try_fmt_vid_cap(struct file *file, void *priv,
return -EINVAL;
}
- field = f->fmt.pix.field;
-
field = V4L2_FIELD_INTERLACED;
tm6000_get_std_res(dev);