diff options
| author | John Stultz <jstultz@google.com> | 2025-03-20 13:03:01 -0700 |
|---|---|---|
| committer | Thomas Gleixner <tglx@linutronix.de> | 2025-03-21 19:16:18 +0100 |
| commit | e40d3709c0225f5f681fd300f65a65ac63b10f83 (patch) | |
| tree | 33d790633c058d09f978f3809000725e616911a7 | |
| parent | 757b000f7b936edf79311ab0971fe465bbda75ea (diff) | |
| download | linux-e40d3709c0225f5f681fd300f65a65ac63b10f83.tar.gz linux-e40d3709c0225f5f681fd300f65a65ac63b10f83.tar.bz2 linux-e40d3709c0225f5f681fd300f65a65ac63b10f83.zip | |
selftests/timers: Improve skew_consistency by testing with other clockids
Lei Chen reported a bug with CLOCK_MONOTONIC_COARSE having inconsistencies
when NTP is adjusting the clock frequency.
This has gone seemingly undetected for ~15 years, illustrating a clear gap
in our testing.
The skew_consistency test is intended to catch this sort of problem, but
was focused on only evaluating CLOCK_MONOTONIC, and thus missed the problem
on CLOCK_MONOTONIC_COARSE.
So adjust the test to run with all clockids for 60 seconds each instead of
10 minutes with just CLOCK_MONOTONIC.
Reported-by: Lei Chen <lei.chen@smartx.com>
Signed-off-by: John Stultz <jstultz@google.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20250320200306.1712599-2-jstultz@google.com
Closes: https://lore.kernel.org/lkml/20250310030004.3705801-1-lei.chen@smartx.com/
| -rw-r--r-- | tools/testing/selftests/timers/skew_consistency.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/testing/selftests/timers/skew_consistency.c b/tools/testing/selftests/timers/skew_consistency.c index 83450145fe65..46c391d7f45d 100644 --- a/tools/testing/selftests/timers/skew_consistency.c +++ b/tools/testing/selftests/timers/skew_consistency.c @@ -47,7 +47,7 @@ int main(int argc, char **argv) pid = fork(); if (!pid) - return system("./inconsistency-check -c 1 -t 600"); + return system("./inconsistency-check -t 60"); ppm = 500; ret = 0; |