diff options
| author | Markus Pargmann <mpa@pengutronix.de> | 2014-12-26 12:41:38 +0100 |
|---|---|---|
| committer | Antonio Quartulli <antonio@meshcoding.com> | 2015-06-03 15:57:24 +0200 |
| commit | e8ad3b1acfbb022b495f12f4ed6e825d5f53546a (patch) | |
| tree | 7228e0ba06eba235553cc106a5640a9017333a11 | |
| parent | a0c77227ffd0ad371cfde84458f440bcde5ab048 (diff) | |
| download | linux-e8ad3b1acfbb022b495f12f4ed6e825d5f53546a.tar.gz linux-e8ad3b1acfbb022b495f12f4ed6e825d5f53546a.tar.bz2 linux-e8ad3b1acfbb022b495f12f4ed6e825d5f53546a.zip | |
batman-adv: main, Convert is_my_mac() to bool
It is much clearer to see a bool type as return value than 'int' for
functions that are supposed to return true or false.
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
| -rw-r--r-- | net/batman-adv/main.c | 11 | ||||
| -rw-r--r-- | net/batman-adv/main.h | 2 |
2 files changed, 8 insertions, 5 deletions
diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c index fd9333dffc97..a22247a61d3e 100644 --- a/net/batman-adv/main.c +++ b/net/batman-adv/main.c @@ -209,10 +209,13 @@ void batadv_mesh_free(struct net_device *soft_iface) * interfaces in the current mesh * @bat_priv: the bat priv with all the soft interface information * @addr: the address to check + * + * Returns 'true' if the mac address was found, false otherwise. */ -int batadv_is_my_mac(struct batadv_priv *bat_priv, const uint8_t *addr) +bool batadv_is_my_mac(struct batadv_priv *bat_priv, const uint8_t *addr) { const struct batadv_hard_iface *hard_iface; + bool is_my_mac = false; rcu_read_lock(); list_for_each_entry_rcu(hard_iface, &batadv_hardif_list, list) { @@ -223,12 +226,12 @@ int batadv_is_my_mac(struct batadv_priv *bat_priv, const uint8_t *addr) continue; if (batadv_compare_eth(hard_iface->net_dev->dev_addr, addr)) { - rcu_read_unlock(); - return 1; + is_my_mac = true; + break; } } rcu_read_unlock(); - return 0; + return is_my_mac; } /** diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h index 026ba37f31a6..96876d29f952 100644 --- a/net/batman-adv/main.h +++ b/net/batman-adv/main.h @@ -195,7 +195,7 @@ extern struct workqueue_struct *batadv_event_workqueue; int batadv_mesh_init(struct net_device *soft_iface); void batadv_mesh_free(struct net_device *soft_iface); -int batadv_is_my_mac(struct batadv_priv *bat_priv, const uint8_t *addr); +bool batadv_is_my_mac(struct batadv_priv *bat_priv, const uint8_t *addr); struct batadv_hard_iface * batadv_seq_print_text_primary_if_get(struct seq_file *seq); int batadv_max_header_len(void); |