diff options
| author | Alexey Khoroshilov <khoroshilov@ispras.ru> | 2019-02-16 00:20:54 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-02-17 15:44:26 -0800 |
| commit | e928b5d6b75e239feb9c6d5488974b6646a0ebc8 (patch) | |
| tree | 0bffd3906507b4886430273ccf540ac352c2d996 | |
| parent | 97dc47a1308a3af46a09b1546cfb869f2e382a81 (diff) | |
| download | linux-e928b5d6b75e239feb9c6d5488974b6646a0ebc8.tar.gz linux-e928b5d6b75e239feb9c6d5488974b6646a0ebc8.tar.bz2 linux-e928b5d6b75e239feb9c6d5488974b6646a0ebc8.zip | |
net: mv643xx_eth: disable clk on error path in mv643xx_eth_shared_probe()
If mv643xx_eth_shared_of_probe() fails, mv643xx_eth_shared_probe()
leaves clk enabled.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/marvell/mv643xx_eth.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c index 2f427271a793..292a668ce88e 100644 --- a/drivers/net/ethernet/marvell/mv643xx_eth.c +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c @@ -2879,7 +2879,7 @@ static int mv643xx_eth_shared_probe(struct platform_device *pdev) ret = mv643xx_eth_shared_of_probe(pdev); if (ret) - return ret; + goto err_put_clk; pd = dev_get_platdata(&pdev->dev); msp->tx_csum_limit = (pd != NULL && pd->tx_csum_limit) ? @@ -2887,6 +2887,11 @@ static int mv643xx_eth_shared_probe(struct platform_device *pdev) infer_hw_params(msp); return 0; + +err_put_clk: + if (!IS_ERR(msp->clk)) + clk_disable_unprepare(msp->clk); + return ret; } static int mv643xx_eth_shared_remove(struct platform_device *pdev) |