summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2020-04-04 17:07:34 +0200
committerHerbert Xu <herbert@gondor.apana.org.au>2020-04-16 16:49:22 +1000
commitf72fed86a5ac80445c7723d3fc782325a23bc7db (patch)
treea0b0f452cc073c0388a5d5f52412d6f240dff167
parentb111418a226f20d3e0b00dbe40bbc4e20b9c2ab5 (diff)
downloadlinux-f72fed86a5ac80445c7723d3fc782325a23bc7db.tar.gz
linux-f72fed86a5ac80445c7723d3fc782325a23bc7db.tar.bz2
linux-f72fed86a5ac80445c7723d3fc782325a23bc7db.zip
hwrng: xgene - Delete an error message in xgene_rng_probe()
The function “platform_get_irq” can log an error already. Thus omit a redundant message for the exception handling in the calling function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
-rw-r--r--drivers/char/hw_random/xgene-rng.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/char/hw_random/xgene-rng.c b/drivers/char/hw_random/xgene-rng.c
index d7516a446987..008e6db9ce01 100644
--- a/drivers/char/hw_random/xgene-rng.c
+++ b/drivers/char/hw_random/xgene-rng.c
@@ -328,10 +328,8 @@ static int xgene_rng_probe(struct platform_device *pdev)
return PTR_ERR(ctx->csr_base);
rc = platform_get_irq(pdev, 0);
- if (rc < 0) {
- dev_err(&pdev->dev, "No IRQ resource\n");
+ if (rc < 0)
return rc;
- }
ctx->irq = rc;
dev_dbg(&pdev->dev, "APM X-Gene RNG BASE %p ALARM IRQ %d",