diff options
| author | Richard Weinberger <richard@nod.at> | 2018-10-13 10:18:41 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-10-13 11:05:02 +0200 |
| commit | f8ccb14fd6c9f58ef766062b7e3929c423580f09 (patch) | |
| tree | c0a6860c48317aeb63cca6e54b14f0e85af3c756 | |
| parent | 79fc170b1f5c36f486d886bfbd59eb4e62321128 (diff) | |
| download | linux-f8ccb14fd6c9f58ef766062b7e3929c423580f09.tar.gz linux-f8ccb14fd6c9f58ef766062b7e3929c423580f09.tar.bz2 linux-f8ccb14fd6c9f58ef766062b7e3929c423580f09.zip | |
ubifs: Fix WARN_ON logic in exit path
ubifs_assert() is not WARN_ON(), so we have to invert
the checks.
Randy faced this warning with UBIFS being a module, since
most users use UBIFS as builtin because UBIFS is the rootfs
nobody noticed so far. :-(
Including me.
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Fixes: 54169ddd382d ("ubifs: Turn two ubifs_assert() into a WARN_ON()")
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | fs/ubifs/super.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c index bf000c8aeffb..fec62e9dfbe6 100644 --- a/fs/ubifs/super.c +++ b/fs/ubifs/super.c @@ -2337,8 +2337,8 @@ late_initcall(ubifs_init); static void __exit ubifs_exit(void) { - WARN_ON(list_empty(&ubifs_infos)); - WARN_ON(atomic_long_read(&ubifs_clean_zn_cnt) == 0); + WARN_ON(!list_empty(&ubifs_infos)); + WARN_ON(atomic_long_read(&ubifs_clean_zn_cnt) != 0); dbg_debugfs_exit(); ubifs_compressors_exit(); |