diff options
| author | Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> | 2021-10-25 13:59:33 -0500 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2021-10-27 11:31:16 +0100 |
| commit | f913582190ddfe2380ecf8ee87b4ff2c8dcb5d48 (patch) | |
| tree | fdc3e529eb0a73db7cc465a257c717e6b6e2286a | |
| parent | 439c06f341aa1f09ad7def774998db1076946c98 (diff) | |
| download | linux-f913582190ddfe2380ecf8ee87b4ff2c8dcb5d48.tar.gz linux-f913582190ddfe2380ecf8ee87b4ff2c8dcb5d48.tar.bz2 linux-f913582190ddfe2380ecf8ee87b4ff2c8dcb5d48.zip | |
ASoC: rockchip: i2s_tdm: improve return value handling
cppcheck reports the following warning:
sound/soc/rockchip/rockchip_i2s_tdm.c:599:9: warning: Identical
condition and return expression 'ret', return value is always 0
[identicalConditionAfterEarlyExit]
return ret;
^
sound/soc/rockchip/rockchip_i2s_tdm.c:594:6: note: If condition 'ret'
is true, the function will return/exit
if (ret)
^
sound/soc/rockchip/rockchip_i2s_tdm.c:599:9: note: Returning identical
expression 'ret'
return ret;
^
While the code is not wrong, it's clearer to return 0 directly.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20211025185933.144327-9-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/rockchip/rockchip_i2s_tdm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/rockchip/rockchip_i2s_tdm.c b/sound/soc/rockchip/rockchip_i2s_tdm.c index e8dee1f95d85..17b9b287853a 100644 --- a/sound/soc/rockchip/rockchip_i2s_tdm.c +++ b/sound/soc/rockchip/rockchip_i2s_tdm.c @@ -596,7 +596,7 @@ static int rockchip_i2s_tdm_clk_set_rate(struct rk_i2s_tdm_dev *i2s_tdm, i2s_tdm->clk_ppm = ppm; - return ret; + return 0; } static int rockchip_i2s_tdm_calibrate_mclk(struct rk_i2s_tdm_dev *i2s_tdm, |