diff options
| author | Aleksandr Mishin <amishin@t-argos.ru> | 2024-06-05 13:49:53 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2024-06-26 18:35:51 +0100 |
| commit | f9f7f29f64454bb20896c7d918c3abc3a1aa487b (patch) | |
| tree | 4a89d2c5b16134c7f51ff7503d15400cd52686b1 | |
| parent | 06462d6f3fb3c445b5abac7b134d9fe9e361113f (diff) | |
| download | linux-f9f7f29f64454bb20896c7d918c3abc3a1aa487b.tar.gz linux-f9f7f29f64454bb20896c7d918c3abc3a1aa487b.tar.bz2 linux-f9f7f29f64454bb20896c7d918c3abc3a1aa487b.zip | |
ASoC: qcom: Adjust issues in case of DT error in asoc_qcom_lpass_cpu_platform_probe()
If IORESOURCE_MEM "lpass-rxtx-cdc-dma-lpm" or "lpass-va-cdc-dma-lpm"
resources is not provided in Device Tree due to any error,
platform_get_resource_byname() will return NULL which is later
dereferenced. According to sound/qcom,lpass-cpu.yaml, these resources
are provided, but DT can be broken due to any error. In such cases driver
must be able to protect itself, since the DT is external data for the
driver.
Adjust this issues by adding NULL return check.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: b138706225c9 ("ASoC: qcom: Add regmap config support for codec dma driver")
Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru>
Link: https://patch.msgid.link/20240605104953.12072-1-amishin@t-argos.ru
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/qcom/lpass-cpu.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c index b0f3e02cb043..5a47f661e0c6 100644 --- a/sound/soc/qcom/lpass-cpu.c +++ b/sound/soc/qcom/lpass-cpu.c @@ -1166,9 +1166,13 @@ int asoc_qcom_lpass_cpu_platform_probe(struct platform_device *pdev) } res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "lpass-rxtx-cdc-dma-lpm"); + if (!res) + return -EINVAL; drvdata->rxtx_cdc_dma_lpm_buf = res->start; res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "lpass-va-cdc-dma-lpm"); + if (!res) + return -EINVAL; drvdata->va_cdc_dma_lpm_buf = res->start; } |