diff options
author | Guenter Roeck <linux@roeck-us.net> | 2021-05-11 13:54:49 -0700 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2021-05-11 16:24:02 -0700 |
commit | faa5f5da809b690542e1108ba66886574ac57d2c (patch) | |
tree | ba213b8c1c78a5157982c7e9ad4526e2c7fe5565 | |
parent | cac6fb015f719104e60b1c68c15ca5b734f57b9c (diff) | |
download | linux-faa5f5da809b690542e1108ba66886574ac57d2c.tar.gz linux-faa5f5da809b690542e1108ba66886574ac57d2c.tar.bz2 linux-faa5f5da809b690542e1108ba66886574ac57d2c.zip |
net/sched: taprio: Drop unnecessary NULL check after container_of
The rcu_head pointer passed to taprio_free_sched_cb is never NULL.
That means that the result of container_of() operations on it is also
never NULL, even though rcu_head is the first element of the structure
embedding it. On top of that, it is misleading to perform a NULL check
on the result of container_of() because the position of the contained
element could change, which would make the check invalid. Remove the
unnecessary NULL check.
This change was made automatically with the following Coccinelle script.
@@
type t;
identifier v;
statement s;
@@
<+...
(
t v = container_of(...);
|
v = container_of(...);
)
...
when != v
- if (\( !v \| v == NULL \) ) s
...+>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/sched/sch_taprio.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c index 5c91df52b8c2..71e8a7a84841 100644 --- a/net/sched/sch_taprio.c +++ b/net/sched/sch_taprio.c @@ -114,9 +114,6 @@ static void taprio_free_sched_cb(struct rcu_head *head) struct sched_gate_list *sched = container_of(head, struct sched_gate_list, rcu); struct sched_entry *entry, *n; - if (!sched) - return; - list_for_each_entry_safe(entry, n, &sched->entries, list) { list_del(&entry->list); kfree(entry); |