summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEric Sandeen <sandeen@redhat.com>2025-02-11 14:14:21 -0600
committerNamjae Jeon <linkinjeon@kernel.org>2025-03-05 21:53:20 +0900
commitfda94a9919fd632033979ad7765a99ae3cab9289 (patch)
treea81abf0d5590179ae4e971bf95a86d0b5f0d906a
parent9da33619e0ca53627641bc97d1b93ec741299111 (diff)
downloadlinux-fda94a9919fd632033979ad7765a99ae3cab9289.tar.gz
linux-fda94a9919fd632033979ad7765a99ae3cab9289.tar.bz2
linux-fda94a9919fd632033979ad7765a99ae3cab9289.zip
exfat: short-circuit zero-byte writes in exfat_file_write_iter
When generic_write_checks() returns zero, it means that iov_iter_count() is zero, and there is no work to do. Simply return success like all other filesystems do, rather than proceeding down the write path, which today yields an -EFAULT in generic_perform_write() via the (fault_in_iov_iter_readable(i, bytes) == bytes) check when bytes == 0. Fixes: 11a347fb6cef ("exfat: change to get file size from DataLength") Reported-by: Noah <kernel-org-10@maxgrass.eu> Signed-off-by: Eric Sandeen <sandeen@redhat.com> Reviewed-by: Yuezhang Mo <Yuezhang.Mo@sony.com> Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
-rw-r--r--fs/exfat/file.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/exfat/file.c b/fs/exfat/file.c
index 05b51e721783..807349d8ea05 100644
--- a/fs/exfat/file.c
+++ b/fs/exfat/file.c
@@ -587,7 +587,7 @@ static ssize_t exfat_file_write_iter(struct kiocb *iocb, struct iov_iter *iter)
valid_size = ei->valid_size;
ret = generic_write_checks(iocb, iter);
- if (ret < 0)
+ if (ret <= 0)
goto unlock;
if (iocb->ki_flags & IOCB_DIRECT) {