summaryrefslogtreecommitdiffstats
path: root/Documentation/power
diff options
context:
space:
mode:
authorErick Archer <erick.archer@gmx.com>2024-01-21 11:43:44 +0100
committerViresh Kumar <viresh.kumar@linaro.org>2024-01-23 11:40:42 +0530
commit9ac3ebaef3cc43ecd136911c44f1427286ee5a05 (patch)
tree7d5754b1f4cba84655b7b9e30fd7ed379c239603 /Documentation/power
parent788715b5f21c6455264fe00a1779e61bec407fe2 (diff)
downloadlinux-9ac3ebaef3cc43ecd136911c44f1427286ee5a05.tar.gz
linux-9ac3ebaef3cc43ecd136911c44f1427286ee5a05.tar.bz2
linux-9ac3ebaef3cc43ecd136911c44f1427286ee5a05.zip
Documentation: power: Use kcalloc() instead of kzalloc()
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors. So, in the example code use the purpose specific kcalloc() function instead of the argument size * count in the kzalloc() function. At the same time, modify the translations accordingly. Signed-off-by: Erick Archer <erick.archer@gmx.com> Reviewed-by: Hu Haowen <2023002089@link.tyut.edu.cn> Reviewed-by: Yanteng Si <siyanteng@loongson.cn> Reviewed-by: Hu Haowen <2023002089@link.tyut.edu.cn> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Diffstat (limited to 'Documentation/power')
-rw-r--r--Documentation/power/opp.rst2
1 files changed, 1 insertions, 1 deletions
diff --git a/Documentation/power/opp.rst b/Documentation/power/opp.rst
index a7c03c470980..1b7f1d854f14 100644
--- a/Documentation/power/opp.rst
+++ b/Documentation/power/opp.rst
@@ -305,7 +305,7 @@ dev_pm_opp_get_opp_count
{
/* Do things */
num_available = dev_pm_opp_get_opp_count(dev);
- speeds = kzalloc(sizeof(u32) * num_available, GFP_KERNEL);
+ speeds = kcalloc(num_available, sizeof(u32), GFP_KERNEL);
/* populate the table in increasing order */
freq = 0;
while (!IS_ERR(opp = dev_pm_opp_find_freq_ceil(dev, &freq))) {