diff options
author | Janusz Krzysztofik <jmkrzyszt@gmail.com> | 2018-09-10 01:44:18 +0200 |
---|---|---|
committer | Tony Lindgren <tony@atomide.com> | 2018-09-20 14:13:43 -0700 |
commit | 1464d031c45da44da6988623c0978b63241df40b (patch) | |
tree | c1b262314cbec52e9f1eab8e9ada1c2ecc1057d3 /LICENSES | |
parent | 0812db94374867324a7811b733f95d5aa06e28b5 (diff) | |
download | linux-1464d031c45da44da6988623c0978b63241df40b.tar.gz linux-1464d031c45da44da6988623c0978b63241df40b.tar.bz2 linux-1464d031c45da44da6988623c0978b63241df40b.zip |
ARM: OMAP1: ams-delta: initialize latch2 pins to safe values
Latch2 pins control a number of on-board devices, namely LCD, NAND,
MODEM and CODEC. Those pins used to be initialized with safe values
from init_machine before that operation was:
1) moved to late_initcall in preparation for conversion of latch2 to
GPIO device - see commit f7519d8c8290 ("ARM: OMAP1: ams-delta: register
latch dependent devices later"),
2) replaced with non-atomic initialization performed by means of
gpio_request_array() - see commit 937eb4bb0058 ("ARM: OMAP1: ams-delta:
convert latches to basic_mmio_gpio"),
3) made completely asynchronous by delegation of GPIO request
operations performed on subsets of pins to respective device drivers in
subsequent commits.
One visible negative result of that disintegration was corrupt keyboard
data reported by serio driver, recently fixed by commit 41f8fee385a0
("ARM: OMAP1: ams-delta: Hog "keybrd_dataout" GPIO pin").
Moreover, initialization of LATCH2_PIN_MODEM_CODEC still performed with
ams_delta_latch2_write() wrapper from late_init() is now done on not
requested GPIO pin.
Reintroduce atomic initialization of latch2 pins at machine_init to
prevent from random values potentially corrupting NAND data or maybe
even destroing other hardware. Also take care of MODEM/CODEC related
pins so MODEM device probe succeeds even if latch2 GPIO device or
dependent regulator is not ready and CODEC can be reached over the
MODEM even if audio driver doesn't take control over
LATCH2_PIN_MODEM_CODEC.
Once done, remove the no longer needed GPIO based implementation of
ams_delta_latch_write() and its frontend macro.
Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
[tony@atomide.com: updated for the header location to remove dependency]
Signed-off-by: Tony Lindgren <tony@atomide.com>
Diffstat (limited to 'LICENSES')
0 files changed, 0 insertions, 0 deletions