diff options
author | Ralf Baechle <ralf@linux-mips.org> | 2008-02-16 22:34:25 +0000 |
---|---|---|
committer | Ralf Baechle <ralf@linux-mips.org> | 2008-02-19 17:01:31 +0000 |
commit | 9a74b3eb22f2d67a5681301f52aca5b7703382c8 (patch) | |
tree | 3ef7b8713edfccc96ad1ce57a431828656d92d82 /arch/mips/mm/cache.c | |
parent | c42d95d6c49ce9c678a9d10aeb3f526c850d66dc (diff) | |
download | linux-9a74b3eb22f2d67a5681301f52aca5b7703382c8.tar.gz linux-9a74b3eb22f2d67a5681301f52aca5b7703382c8.tar.bz2 linux-9a74b3eb22f2d67a5681301f52aca5b7703382c8.zip |
[MIPS] Fix buggy invocations of kmap_coherent()
kmap_coherent will only work correctly if the page it is called on is
not marked dirty. If it's dirty the kernel address of the page should
be used instead of a temporary mapping.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Diffstat (limited to 'arch/mips/mm/cache.c')
-rw-r--r-- | arch/mips/mm/cache.c | 15 |
1 files changed, 10 insertions, 5 deletions
diff --git a/arch/mips/mm/cache.c b/arch/mips/mm/cache.c index 81f30ac2bff9..6a24651971df 100644 --- a/arch/mips/mm/cache.c +++ b/arch/mips/mm/cache.c @@ -92,12 +92,17 @@ EXPORT_SYMBOL(__flush_dcache_page); void __flush_anon_page(struct page *page, unsigned long vmaddr) { - if (pages_do_alias((unsigned long)page_address(page), vmaddr)) { - void *kaddr; + unsigned long addr = (unsigned long) page_address(page); - kaddr = kmap_coherent(page, vmaddr); - flush_data_cache_page((unsigned long)kaddr); - kunmap_coherent(); + if (pages_do_alias(addr, vmaddr)) { + if (page_mapped(page) && !Page_dcache_dirty(page)) { + void *kaddr; + + kaddr = kmap_coherent(page, vmaddr); + flush_data_cache_page((unsigned long)kaddr); + kunmap_coherent(); + } else + flush_data_cache_page(addr); } } |