diff options
author | Ulrich Weigand <ulrich.weigand@de.ibm.com> | 2014-02-14 19:21:03 +0100 |
---|---|---|
committer | Anton Blanchard <anton@samba.org> | 2014-04-23 10:05:24 +1000 |
commit | 752a6422fec3c0f5f9d4ac43d92f5dd13e22fde4 (patch) | |
tree | 6ef91c1ad3c067345ce45bb6d7730ab9f38c9241 /arch/powerpc/platforms | |
parent | b37c10d128a2fa3256d4e67c184177270eac4b86 (diff) | |
download | linux-752a6422fec3c0f5f9d4ac43d92f5dd13e22fde4.tar.gz linux-752a6422fec3c0f5f9d4ac43d92f5dd13e22fde4.tar.bz2 linux-752a6422fec3c0f5f9d4ac43d92f5dd13e22fde4.zip |
powerpc: Fix unsafe accesses to parameter area in ELFv2
Some of the assembler files in lib/ make use of the fact that in the
ELFv1 ABI, the caller guarantees to provide stack space to save the
parameter registers r3 ... r10. This guarantee is no longer present
in ELFv2 for functions that have no variable argument list and no
more than 8 arguments.
Change the affected routines to temporarily store registers in the
red zone and/or the top of their own stack frame (in the space
provided to save r31 .. r29, which is actually not used in these
routines).
In opal_query_takeover, simply always allocate a stack frame;
the routine is not performance critical.
Signed-off-by: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Signed-off-by: Anton Blanchard <anton@samba.org>
Diffstat (limited to 'arch/powerpc/platforms')
-rw-r--r-- | arch/powerpc/platforms/powernv/opal-takeover.S | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/arch/powerpc/platforms/powernv/opal-takeover.S b/arch/powerpc/platforms/powernv/opal-takeover.S index 3cd262897c27..11a3169ee583 100644 --- a/arch/powerpc/platforms/powernv/opal-takeover.S +++ b/arch/powerpc/platforms/powernv/opal-takeover.S @@ -21,11 +21,13 @@ _GLOBAL(opal_query_takeover) mfcr r0 stw r0,8(r1) + stdu r1,-STACKFRAMESIZE(r1) std r3,STK_PARAM(R3)(r1) std r4,STK_PARAM(R4)(r1) li r3,H_HAL_TAKEOVER li r4,H_HAL_TAKEOVER_QUERY_MAGIC HVSC + addi r1,r1,STACKFRAMESIZE ld r10,STK_PARAM(R3)(r1) std r4,0(r10) ld r10,STK_PARAM(R4)(r1) |