diff options
| author | David S. Miller <davem@davemloft.net> | 2011-12-22 13:23:59 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-12-22 13:46:53 -0800 |
| commit | 7cc8583372a21d98a23b703ad96cab03180b5030 (patch) | |
| tree | 15c342c336b72e431ce96f1b4d27930b9f58ebe2 /arch/sparc/kernel | |
| parent | b3b1b70e62a603f473619dbebc3b3d23f535e6f8 (diff) | |
| download | linux-7cc8583372a21d98a23b703ad96cab03180b5030.tar.gz linux-7cc8583372a21d98a23b703ad96cab03180b5030.tar.bz2 linux-7cc8583372a21d98a23b703ad96cab03180b5030.zip | |
sparc64: Fix MSIQ HV call ordering in pci_sun4v_msiq_build_irq().
This silently was working for many years and stopped working on
Niagara-T3 machines.
We need to set the MSIQ to VALID before we can set it's state to IDLE.
On Niagara-T3, setting the state to IDLE first was causing HV_EINVAL
errors. The hypervisor documentation says, rather ambiguously, that
the MSIQ must be "initialized" before one can set the state.
I previously understood this to mean merely that a successful setconf()
operation has been performed on the MSIQ, which we have done at this
point. But it seems to also mean that it has been set VALID too.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'arch/sparc/kernel')
| -rw-r--r-- | arch/sparc/kernel/pci_sun4v.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/sparc/kernel/pci_sun4v.c b/arch/sparc/kernel/pci_sun4v.c index b272cda35a01..af5755d20fbe 100644 --- a/arch/sparc/kernel/pci_sun4v.c +++ b/arch/sparc/kernel/pci_sun4v.c @@ -849,10 +849,10 @@ static int pci_sun4v_msiq_build_irq(struct pci_pbm_info *pbm, if (!irq) return -ENOMEM; - if (pci_sun4v_msiq_setstate(pbm->devhandle, msiqid, HV_MSIQSTATE_IDLE)) - return -EINVAL; if (pci_sun4v_msiq_setvalid(pbm->devhandle, msiqid, HV_MSIQ_VALID)) return -EINVAL; + if (pci_sun4v_msiq_setstate(pbm->devhandle, msiqid, HV_MSIQSTATE_IDLE)) + return -EINVAL; return irq; } |