diff options
author | Richard Weinberger <richard@nod.at> | 2013-08-18 13:30:08 +0200 |
---|---|---|
committer | Richard Weinberger <richard@nod.at> | 2013-09-07 10:56:58 +0200 |
commit | 91d44ff860a9e9c0db81a89cbc24fa31fbd8e6d3 (patch) | |
tree | bb14601ab3afbcec3cb8d7d0f207d09cfc792268 /arch/um/os-Linux/util.c | |
parent | bc1d72e73be63a7c4a07eb10cf51e91f20bf6076 (diff) | |
download | linux-91d44ff860a9e9c0db81a89cbc24fa31fbd8e6d3.tar.gz linux-91d44ff860a9e9c0db81a89cbc24fa31fbd8e6d3.tar.bz2 linux-91d44ff860a9e9c0db81a89cbc24fa31fbd8e6d3.zip |
um: Cleanup SIGTERM handling
Richard reported that some UML processes survive if the UML
main process receives a SIGTERM.
This issue was caused by a wrongly placed signal(SIGTERM, SIG_DFL)
in init_new_thread_signals().
It disabled the UML exit handler accidently for some processes.
The correct solution is to disable the fatal handler for all
UML helper threads/processes.
Such that last_ditch_exit() does not get called multiple times
and all processes can exit due to SIGTERM.
Reported-and-tested-by: Richard W.M. Jones <rjones@redhat.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Diffstat (limited to 'arch/um/os-Linux/util.c')
-rw-r--r-- | arch/um/os-Linux/util.c | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/arch/um/os-Linux/util.c b/arch/um/os-Linux/util.c index 492ef5e6e166..faee55ef6d2f 100644 --- a/arch/um/os-Linux/util.c +++ b/arch/um/os-Linux/util.c @@ -94,6 +94,16 @@ static inline void __attribute__ ((noreturn)) uml_abort(void) exit(127); } +/* + * UML helper threads must not handle SIGWINCH/INT/TERM + */ +void os_fix_helper_signals(void) +{ + signal(SIGWINCH, SIG_IGN); + signal(SIGINT, SIG_DFL); + signal(SIGTERM, SIG_DFL); +} + void os_dump_core(void) { int pid; |