diff options
| author | Dongli Zhang <dongli.zhang@oracle.com> | 2023-10-01 14:36:37 -0700 |
|---|---|---|
| committer | Sean Christopherson <seanjc@google.com> | 2023-10-18 13:49:29 -0700 |
| commit | 2081a8450ef803e2e1136a80975eebc8682879b5 (patch) | |
| tree | 09a009f3f993d75842a4082f6c16ab3c5e004bfa /arch/x86 | |
| parent | d6800af51c76b6dae20e6023bbdc9b3da3ab5121 (diff) | |
| download | linux-2081a8450ef803e2e1136a80975eebc8682879b5.tar.gz linux-2081a8450ef803e2e1136a80975eebc8682879b5.tar.bz2 linux-2081a8450ef803e2e1136a80975eebc8682879b5.zip | |
KVM: x86: remove always-false condition in kvmclock_sync_fn
The 'kvmclock_periodic_sync' is a readonly param that cannot change after
bootup.
The kvm_arch_vcpu_postcreate() is not going to schedule the
kvmclock_sync_work if kvmclock_periodic_sync == false.
As a result, the "if (!kvmclock_periodic_sync)" can never be true if the
kvmclock_sync_work = kvmclock_sync_fn() is scheduled.
Link: https://lore.kernel.org/kvm/a461bf3f-c17e-9c3f-56aa-726225e8391d@oracle.com
Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
Link: https://lore.kernel.org/r/20231001213637.76686-1-dongli.zhang@oracle.com
Signed-off-by: Sean Christopherson <seanjc@google.com>
Diffstat (limited to 'arch/x86')
| -rw-r--r-- | arch/x86/kvm/x86.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 051ca1978442..2b1d8e22502b 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -3374,9 +3374,6 @@ static void kvmclock_sync_fn(struct work_struct *work) kvmclock_sync_work); struct kvm *kvm = container_of(ka, struct kvm, arch); - if (!kvmclock_periodic_sync) - return; - schedule_delayed_work(&kvm->arch.kvmclock_update_work, 0); schedule_delayed_work(&kvm->arch.kvmclock_sync_work, KVMCLOCK_SYNC_PERIOD); |