diff options
| author | Josh Poimboeuf <jpoimboe@kernel.org> | 2023-02-13 23:05:53 -0800 |
|---|---|---|
| committer | Josh Poimboeuf <jpoimboe@kernel.org> | 2023-03-08 08:44:27 -0800 |
| commit | d08e12e8126ec88d6cb1a7eb160d8d7b52c8699f (patch) | |
| tree | 654add8c27961f4d8481c5d9e75afe9856bfa020 /arch/xtensa/kernel | |
| parent | eab89405b6b59947ee29cc21fb39ead66142c9b5 (diff) | |
| download | linux-d08e12e8126ec88d6cb1a7eb160d8d7b52c8699f.tar.gz linux-d08e12e8126ec88d6cb1a7eb160d8d7b52c8699f.tar.bz2 linux-d08e12e8126ec88d6cb1a7eb160d8d7b52c8699f.zip | |
xtensa/cpu: Make sure cpu_die() doesn't return
cpu_die() doesn't return. Make that more explicit with a BUG().
BUG() is preferable to unreachable() because BUG() is a more explicit
failure mode and avoids undefined behavior like falling off the edge of
the function into whatever code happens to be next.
Link: https://lore.kernel.org/r/cca346b5c87693499e630291d78fb0bf12c24290.1676358308.git.jpoimboe@kernel.org
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Diffstat (limited to 'arch/xtensa/kernel')
| -rw-r--r-- | arch/xtensa/kernel/smp.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/arch/xtensa/kernel/smp.c b/arch/xtensa/kernel/smp.c index 4dc109dd6214..7bad78495536 100644 --- a/arch/xtensa/kernel/smp.c +++ b/arch/xtensa/kernel/smp.c @@ -341,6 +341,8 @@ void __ref cpu_die(void) __asm__ __volatile__( " movi a2, cpu_restart\n" " jx a2\n"); + + BUG(); } #endif /* CONFIG_HOTPLUG_CPU */ |