diff options
| author | Masahiro Yamada <yamada.masahiro@socionext.com> | 2019-05-21 13:03:27 +0900 |
|---|---|---|
| committer | Paul Burton <paul.burton@mips.com> | 2019-05-22 18:46:15 -0700 |
| commit | 3dd0aade5911d21abb35fbd4f71c3f52c25891d1 (patch) | |
| tree | 8be0411242f6974bd48bc22aac08347a3f062e09 /arch | |
| parent | 6074c33c6b2eabc70867ef76d57ca256e9ea9da7 (diff) | |
| download | linux-3dd0aade5911d21abb35fbd4f71c3f52c25891d1.tar.gz linux-3dd0aade5911d21abb35fbd4f71c3f52c25891d1.tar.bz2 linux-3dd0aade5911d21abb35fbd4f71c3f52c25891d1.zip | |
MIPS: remove a space after -I to cope with header search paths for VDSO
Commit 9cc342f6c4a0 ("treewide: prefix header search paths with
$(srctree)/") caused a build error for MIPS VDSO.
CC arch/mips/vdso/gettimeofday.o
In file included from ../arch/mips/vdso/vdso.h:26,
from ../arch/mips/vdso/gettimeofday.c:11:
../arch/mips/include/asm/page.h:12:10: fatal error: spaces.h: No such file or directory
#include <spaces.h>
^~~~~~~~~~
The cause of the error is a missing space after the compiler flag -I .
Kbuild used to have a global restriction "no space after -I", but
commit 48f6e3cf5bc6 ("kbuild: do not drop -I without parameter") got
rid of it. Having a space after -I is no longer a big deal as far as
Kbuild is concerned.
It is still a big deal for MIPS because arch/mips/vdso/Makefile
filters the header search paths, like this:
ccflags-vdso := \
$(filter -I%,$(KBUILD_CFLAGS)) \
..., which relies on the assumption that there is no space after -I .
Fixes: 9cc342f6c4a0 ("treewide: prefix header search paths with $(srctree)/")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Paul Burton <paul.burton@mips.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: James Hogan <jhogan@kernel.org>
Cc: linux-mips@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Diffstat (limited to 'arch')
| -rw-r--r-- | arch/mips/pnx833x/Platform | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/mips/pnx833x/Platform b/arch/mips/pnx833x/Platform index 6b1a847d593f..287260669551 100644 --- a/arch/mips/pnx833x/Platform +++ b/arch/mips/pnx833x/Platform @@ -1,5 +1,5 @@ # NXP STB225 platform-$(CONFIG_SOC_PNX833X) += pnx833x/ -cflags-$(CONFIG_SOC_PNX833X) += -I $(srctree)/arch/mips/include/asm/mach-pnx833x +cflags-$(CONFIG_SOC_PNX833X) += -I$(srctree)/arch/mips/include/asm/mach-pnx833x load-$(CONFIG_NXP_STB220) += 0xffffffff80001000 load-$(CONFIG_NXP_STB225) += 0xffffffff80001000 |