summaryrefslogtreecommitdiffstats
path: root/block
diff options
context:
space:
mode:
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-01-23 14:48:54 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-01-31 14:07:59 +0100
commit36991ca68db9dd43bac7f3519f080ee3939263ef (patch)
tree49a095083f83399fa032a7e3264a1509d79dc983 /block
parent2c1cf00eeacb784781cf1c9896b8af001246d339 (diff)
downloadlinux-36991ca68db9dd43bac7f3519f080ee3939263ef.tar.gz
linux-36991ca68db9dd43bac7f3519f080ee3939263ef.tar.bz2
linux-36991ca68db9dd43bac7f3519f080ee3939263ef.zip
blk-mq: protect debugfs_create_files() from failures
If debugfs were to return a non-NULL error for a debugfs call, using that pointer later in debugfs_create_files() would crash. Fix that by properly checking the pointer before referencing it. Reported-by: Michal Hocko <mhocko@kernel.org> Reported-and-tested-by: syzbot+b382ba6a802a3d242790@syzkaller.appspotmail.com Reported-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'block')
-rw-r--r--block/blk-mq-debugfs.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
index 90d68760af08..777638f597aa 100644
--- a/block/blk-mq-debugfs.c
+++ b/block/blk-mq-debugfs.c
@@ -838,6 +838,9 @@ static const struct blk_mq_debugfs_attr blk_mq_debugfs_ctx_attrs[] = {
static bool debugfs_create_files(struct dentry *parent, void *data,
const struct blk_mq_debugfs_attr *attr)
{
+ if (IS_ERR_OR_NULL(parent))
+ return false;
+
d_inode(parent)->i_private = data;
for (; attr->name; attr++) {