summaryrefslogtreecommitdiffstats
path: root/block
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@lst.de>2021-07-01 10:16:37 +0200
committerJens Axboe <axboe@kernel.dk>2021-07-01 10:21:24 -0600
commit498dcc13fd6463de29b94e160f40ed04d5477cd8 (patch)
treefac09e7780f90adc89db1d48fa7140a37e11af70 /block
parent2b7a8dc06d0f840345ae3c7ed6f9d55962b5f54a (diff)
downloadlinux-498dcc13fd6463de29b94e160f40ed04d5477cd8.tar.gz
linux-498dcc13fd6463de29b94e160f40ed04d5477cd8.tar.bz2
linux-498dcc13fd6463de29b94e160f40ed04d5477cd8.zip
block: grab a device refcount in disk_uevent
Sending uevents requires the struct device to be alive. To ensure that grab the device refcount instead of just an inode reference. Fixes: bc359d03c7ec ("block: add a disk_uevent helper") Signed-off-by: Christoph Hellwig <hch@lst.de> Link: https://lore.kernel.org/r/20210701081638.246552-2-hch@lst.de Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block')
-rw-r--r--block/genhd.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/block/genhd.c b/block/genhd.c
index 79aa40b4c39c..af4d2ab4a633 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -365,12 +365,12 @@ void disk_uevent(struct gendisk *disk, enum kobject_action action)
xa_for_each(&disk->part_tbl, idx, part) {
if (bdev_is_partition(part) && !bdev_nr_sectors(part))
continue;
- if (!bdgrab(part))
+ if (!kobject_get_unless_zero(&part->bd_device.kobj))
continue;
rcu_read_unlock();
kobject_uevent(bdev_kobj(part), action);
- bdput(part);
+ put_device(&part->bd_device);
rcu_read_lock();
}
rcu_read_unlock();