diff options
author | Stefan Haberland <sth@linux.ibm.com> | 2020-03-12 14:17:15 +0100 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2020-03-12 07:24:52 -0600 |
commit | 5e6bdd37c5526ef01326df5dabb93011ee89237e (patch) | |
tree | 9a70a06a5914b6e8f05a8f1be105ea6f1b916833 /block | |
parent | dcd6589b11d3b1e71f516a87a7b9646ed356b4c0 (diff) | |
download | linux-5e6bdd37c5526ef01326df5dabb93011ee89237e.tar.gz linux-5e6bdd37c5526ef01326df5dabb93011ee89237e.tar.bz2 linux-5e6bdd37c5526ef01326df5dabb93011ee89237e.zip |
s390/dasd: fix data corruption for thin provisioned devices
Devices are formatted in multiple of tracks.
For an Extent Space Efficient (ESE) volume we get errors when accessing
unformatted tracks. In this case the driver either formats the track on
the flight for write requests or returns zero data for read requests.
In case a request spans multiple tracks, the indication of an unformatted
track presented for the first track is incorrectly applied to all tracks
covered by the request. As a result, tracks containing data will be handled
as empty, resulting in zero data being returned on read, or overwriting
existing data with zero on write.
Fix by determining the track that gets the NRF error.
For write requests only format the track that is surely not formatted.
For Read requests all tracks before have returned valid data and should not
be touched.
All tracks after the unformatted track might be formatted or not. Those are
returned to the blocklayer to build a new request.
When using alias devices there is a chance that multiple write requests
trigger a format of the same track which might lead to data loss. Ensure
that a track is formatted only once by maintaining a list of currently
processed tracks.
Fixes: 5e2b17e712cf ("s390/dasd: Add dynamic formatting support for ESE volumes")
Cc: stable@vger.kernel.org # 5.3+
Signed-off-by: Stefan Haberland <sth@linux.ibm.com>
Reviewed-by: Jan Hoeppner <hoeppner@linux.ibm.com>
Reviewed-by: Peter Oberparleiter <oberpar@linux.ibm.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block')
0 files changed, 0 insertions, 0 deletions