diff options
author | Jakub Kicinski <kuba@kernel.org> | 2021-09-13 15:53:30 -0700 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2021-09-15 15:46:02 +0100 |
commit | 1e080f17750d1083e8a32f7b350584ae1cd7ff20 (patch) | |
tree | 6de7b6209b6504d043342c3108e9fdc766ca04d4 /crypto/ecrdsa.c | |
parent | c506cc5bc6e33a20ca615043aa3ddb2da4b8c210 (diff) | |
download | linux-1e080f17750d1083e8a32f7b350584ae1cd7ff20.tar.gz linux-1e080f17750d1083e8a32f7b350584ae1cd7ff20.tar.bz2 linux-1e080f17750d1083e8a32f7b350584ae1cd7ff20.zip |
net: sched: update default qdisc visibility after Tx queue cnt changes
mq / mqprio make the default child qdiscs visible. They only do
so for the qdiscs which are within real_num_tx_queues when the
device is registered. Depending on order of calls in the driver,
or if user space changes config via ethtool -L the number of
qdiscs visible under tc qdisc show will differ from the number
of queues. This is confusing to users and potentially to system
configuration scripts which try to make sure qdiscs have the
right parameters.
Add a new Qdisc_ops callback and make relevant qdiscs TTRT.
Note that this uncovers the "shortcut" created by
commit 1f27cde313d7 ("net: sched: use pfifo_fast for non real queues")
The default child qdiscs beyond initial real_num_tx are always
pfifo_fast, no matter what the sysfs setting is. Fixing this
gets a little tricky because we'd need to keep a reference
on whatever the default qdisc was at the time of creation.
In practice this is likely an non-issue the qdiscs likely have
to be configured to non-default settings, so whatever user space
is doing such configuration can replace the pfifos... now that
it will see them.
Reported-by: Matthew Massey <matthewmassey@fb.com>
Reviewed-by: Dave Taht <dave.taht@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'crypto/ecrdsa.c')
0 files changed, 0 insertions, 0 deletions