summaryrefslogtreecommitdiffstats
path: root/crypto
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2018-10-27 15:49:26 +0100
committerHerbert Xu <herbert@gondor.apana.org.au>2018-11-09 17:41:39 +0800
commitb1e3874c75ab15288f573b3532e507c37e8e7656 (patch)
tree3a708f100e95187c374c04c0d318ee7c1aea43f1 /crypto
parent7da66670775d201f633577f5b15a4bbeebaaa2b0 (diff)
downloadlinux-b1e3874c75ab15288f573b3532e507c37e8e7656.tar.gz
linux-b1e3874c75ab15288f573b3532e507c37e8e7656.tar.bz2
linux-b1e3874c75ab15288f573b3532e507c37e8e7656.zip
pcrypt: use format specifier in kobject_add
Passing string 'name' as the format specifier is potentially hazardous because name could (although very unlikely to) have a format specifier embedded in it causing issues when parsing the non-existent arguments to these. Follow best practice by using the "%s" format string for the string 'name'. Cleans up clang warning: crypto/pcrypt.c:397:40: warning: format string is not a string literal (potentially insecure) [-Wformat-security] Fixes: a3fb1e330dd2 ("pcrypt: Added sysfs interface to pcrypt") Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto')
-rw-r--r--crypto/pcrypt.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/crypto/pcrypt.c b/crypto/pcrypt.c
index f8ec3d4ba4a8..a5718c0a3dc4 100644
--- a/crypto/pcrypt.c
+++ b/crypto/pcrypt.c
@@ -394,7 +394,7 @@ static int pcrypt_sysfs_add(struct padata_instance *pinst, const char *name)
int ret;
pinst->kobj.kset = pcrypt_kset;
- ret = kobject_add(&pinst->kobj, NULL, name);
+ ret = kobject_add(&pinst->kobj, NULL, "%s", name);
if (!ret)
kobject_uevent(&pinst->kobj, KOBJ_ADD);