diff options
| author | Koby Elbaz <kelbaz@habana.ai> | 2023-03-26 18:22:57 +0300 |
|---|---|---|
| committer | Oded Gabbay <ogabbay@kernel.org> | 2023-04-08 10:39:34 +0300 |
| commit | c19350efa9dae7f4474d7847ab7d6e667082fd18 (patch) | |
| tree | 7ad026151127ba4755423b33cb764192d5fc2bc0 /drivers/accel | |
| parent | 802f25b6c2c0377c681dd1e4f799a648c3df50dd (diff) | |
| download | linux-c19350efa9dae7f4474d7847ab7d6e667082fd18.tar.gz linux-c19350efa9dae7f4474d7847ab7d6e667082fd18.tar.bz2 linux-c19350efa9dae7f4474d7847ab7d6e667082fd18.zip | |
accel/habanalabs: don't wait for STS_OK after sending COMMS WFE
Sending COMMS_GOTO_WFE instructs the FW's CPU to halt (WFE state).
Once sent, FW's CPU isn't expected to continue communicating with LKD.
Therefore, the stage of waiting for COMMS_STS_OK should be skipped or
else waiting for COMMS_STS_OK will simply timeout, which will trigger
unexpected behavior.
Signed-off-by: Koby Elbaz <kelbaz@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
Diffstat (limited to 'drivers/accel')
| -rw-r--r-- | drivers/accel/habanalabs/common/firmware_if.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/accel/habanalabs/common/firmware_if.c b/drivers/accel/habanalabs/common/firmware_if.c index 781256dd49ad..59f61ec66445 100644 --- a/drivers/accel/habanalabs/common/firmware_if.c +++ b/drivers/accel/habanalabs/common/firmware_if.c @@ -1278,7 +1278,7 @@ void hl_fw_ask_halt_machine_without_linux(struct hl_device *hdev) /* Stop device CPU to make sure nothing bad happens */ if (hdev->asic_prop.dynamic_fw_load) { rc = hl_fw_dynamic_send_protocol_cmd(hdev, &hdev->fw_loader, - COMMS_GOTO_WFE, 0, true, + COMMS_GOTO_WFE, 0, false, hdev->fw_loader.cpu_timeout); if (rc) dev_err(hdev->dev, "Failed sending COMMS_GOTO_WFE\n"); |