summaryrefslogtreecommitdiffstats
path: root/drivers/acpi/acpi_memhotplug.c
diff options
context:
space:
mode:
authorWen Congyang <wency@cn.fujitsu.com>2012-11-16 02:08:16 +0100
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2012-11-16 02:08:16 +0100
commite0b7b24dd9559fcda0f8bfd6acbcad81682c4fdd (patch)
treec65d30553948fbd64cda945b1a8eaf4a45dd064c /drivers/acpi/acpi_memhotplug.c
parent386e52b95550db87c93455e3c0efe3cc4543f036 (diff)
downloadlinux-e0b7b24dd9559fcda0f8bfd6acbcad81682c4fdd.tar.gz
linux-e0b7b24dd9559fcda0f8bfd6acbcad81682c4fdd.tar.bz2
linux-e0b7b24dd9559fcda0f8bfd6acbcad81682c4fdd.zip
ACPI / memhotplug: free memory device if acpi_memory_enable_device() failed
If acpi_memory_enable_device() fails, acpi_memory_enable_device() will return a non-zero value, which means we fail to bind the memory device to this driver. So we should free memory device before acpi_memory_device_add() returns. Signed-off-by: Wen Congyang <wency@cn.fujitsu.com> Reviewed-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> Acked-by: David Rientjes <rientjes@google.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/acpi/acpi_memhotplug.c')
-rw-r--r--drivers/acpi/acpi_memhotplug.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
index c5e7b6d08ef3..e52ad5d3792d 100644
--- a/drivers/acpi/acpi_memhotplug.c
+++ b/drivers/acpi/acpi_memhotplug.c
@@ -421,9 +421,11 @@ static int acpi_memory_device_add(struct acpi_device *device)
if (!acpi_memory_check_device(mem_device)) {
/* call add_memory func */
result = acpi_memory_enable_device(mem_device);
- if (result)
+ if (result) {
printk(KERN_ERR PREFIX
"Error in acpi_memory_enable_device\n");
+ acpi_memory_device_free(mem_device);
+ }
}
return result;
}