summaryrefslogtreecommitdiffstats
path: root/drivers/acpi/dock.c
diff options
context:
space:
mode:
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>2013-07-17 08:33:25 +0800
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2013-07-26 00:34:00 +0200
commit0177f29fea534ef5e6af2d76e9a9be0fdd325c4d (patch)
treee1a7db8e94217cf39cb5c9193305f0149fd3f6c9 /drivers/acpi/dock.c
parent2efbca4dfc7b43951de6dd1647f9eebda9d4372b (diff)
downloadlinux-0177f29fea534ef5e6af2d76e9a9be0fdd325c4d.tar.gz
linux-0177f29fea534ef5e6af2d76e9a9be0fdd325c4d.tar.bz2
linux-0177f29fea534ef5e6af2d76e9a9be0fdd325c4d.zip
ACPI / dock: fix error return code in dock_add()
Fix to return -ENODEV in the acpi notify handler install error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/acpi/dock.c')
-rw-r--r--drivers/acpi/dock.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c
index f601658a4ad2..b527c1bd8bb2 100644
--- a/drivers/acpi/dock.c
+++ b/drivers/acpi/dock.c
@@ -881,8 +881,10 @@ static int __init dock_add(acpi_handle handle)
status = acpi_install_notify_handler(handle, ACPI_SYSTEM_NOTIFY,
dock_notify_handler, dock_station);
- if (ACPI_FAILURE(status))
+ if (ACPI_FAILURE(status)) {
+ ret = -ENODEV;
goto err_rmgroup;
+ }
dock_station_count++;
list_add(&dock_station->sibling, &dock_stations);