summaryrefslogtreecommitdiffstats
path: root/drivers/acpi
diff options
context:
space:
mode:
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>2013-08-08 16:19:19 +0200
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2013-08-09 00:54:52 +0200
commit464c114717ae221202ebdbd9aa216035b4626f18 (patch)
tree52909cd2cb11e4294e8aa4f2e6f3943a0a0c27de /drivers/acpi
parent3342c753bdeb29ec29d721c7ce38d283cc969174 (diff)
downloadlinux-464c114717ae221202ebdbd9aa216035b4626f18.tar.gz
linux-464c114717ae221202ebdbd9aa216035b4626f18.tar.bz2
linux-464c114717ae221202ebdbd9aa216035b4626f18.zip
ACPI: Print diagnostic messages if device links cannot be created
Although the device links created by acpi_bind_one() are not essential from the kernel functionality point of view, user space may be confused when they are missing, so print diagnostic messages to the kernel log if they can't be created. Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Acked-by: Toshi Kani <toshi.kani@hp.com>
Diffstat (limited to 'drivers/acpi')
-rw-r--r--drivers/acpi/glue.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c
index f3ead0ce37ab..94672297e1b1 100644
--- a/drivers/acpi/glue.c
+++ b/drivers/acpi/glue.c
@@ -252,8 +252,15 @@ int acpi_bind_one(struct device *dev, acpi_handle handle)
acpi_physnode_link_name(physical_node_name, node_id);
retval = sysfs_create_link(&acpi_dev->dev.kobj, &dev->kobj,
physical_node_name);
+ if (retval)
+ dev_err(&acpi_dev->dev, "Failed to create link %s (%d)\n",
+ physical_node_name, retval);
+
retval = sysfs_create_link(&dev->kobj, &acpi_dev->dev.kobj,
"firmware_node");
+ if (retval)
+ dev_err(dev, "Failed to create link firmware_node (%d)\n",
+ retval);
mutex_unlock(&acpi_dev->physical_node_lock);