diff options
| author | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-02-02 15:16:20 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-02-08 13:33:10 +0100 |
| commit | 8deb87b1e810dd558371e88ffd44339fbef27870 (patch) | |
| tree | e9eb2767f7498929e88040e269edcf90aaa0f4a6 /drivers/base | |
| parent | 5cdc03c5cf471a215c57e540cc86be613c0ba457 (diff) | |
| download | linux-8deb87b1e810dd558371e88ffd44339fbef27870.tar.gz linux-8deb87b1e810dd558371e88ffd44339fbef27870.tar.bz2 linux-8deb87b1e810dd558371e88ffd44339fbef27870.zip | |
drivers: base: component: fix memory leak with using debugfs_lookup()
When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time. To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic
at once.
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Link: https://lore.kernel.org/r/20230202141621.2296458-1-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/base')
| -rw-r--r-- | drivers/base/component.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/base/component.c b/drivers/base/component.c index 5eadeac6c532..7dbf14a1d915 100644 --- a/drivers/base/component.c +++ b/drivers/base/component.c @@ -125,7 +125,7 @@ static void component_debugfs_add(struct aggregate_device *m) static void component_debugfs_del(struct aggregate_device *m) { - debugfs_remove(debugfs_lookup(dev_name(m->parent), component_debugfs_dir)); + debugfs_lookup_and_remove(dev_name(m->parent), component_debugfs_dir); } #else |