diff options
author | AliOS system security <alios_sys_security@linux.alibaba.com> | 2018-11-05 15:31:42 +0800 |
---|---|---|
committer | Mike Snitzer <snitzer@redhat.com> | 2018-12-18 09:02:26 -0500 |
commit | 8d683dcd65c037efc9fb38c696ec9b65b306e573 (patch) | |
tree | 1b45394594d37d7ecc24a77d6ac07767ea4323e9 /drivers/bcma/sprom.c | |
parent | d7e6b8dfc7bcb3f4f3a18313581f67486a725b52 (diff) | |
download | linux-8d683dcd65c037efc9fb38c696ec9b65b306e573.tar.gz linux-8d683dcd65c037efc9fb38c696ec9b65b306e573.tar.bz2 linux-8d683dcd65c037efc9fb38c696ec9b65b306e573.zip |
dm crypt: use u64 instead of sector_t to store iv_offset
The iv_offset in the mapping table of crypt target is a 64bit number when
IV algorithm is plain64, plain64be, essiv or benbi. It will be assigned to
iv_offset of struct crypt_config, cc_sector of struct convert_context and
iv_sector of struct dm_crypt_request. These structures members are defined
as a sector_t. But sector_t is 32bit when CONFIG_LBDAF is not set in 32bit
kernel. In this situation sector_t is not big enough to store the 64bit
iv_offset.
Here is a reproducer.
Prepare test image and device (loop is automatically allocated by cryptsetup):
# dd if=/dev/zero of=tst.img bs=1M count=1
# echo "tst"|cryptsetup open --type plain -c aes-xts-plain64 \
--skip 500000000000000000 tst.img test
On 32bit system (use IV offset value that overflows to 64bit; CONFIG_LBDAF if off)
and device checksum is wrong:
# dmsetup table test --showkeys
0 2048 crypt aes-xts-plain64 dfa7cfe3c481f2239155739c42e539ae8f2d38f304dcc89d20b26f69daaf0933 3551657984 7:0 0
# sha256sum /dev/mapper/test
533e25c09176632b3794f35303488c4a8f3f965dffffa6ec2df347c168cb6c19 /dev/mapper/test
On 64bit system (and on 32bit system with the patch), table and checksum is now correct:
# dmsetup table test --showkeys
0 2048 crypt aes-xts-plain64 dfa7cfe3c481f2239155739c42e539ae8f2d38f304dcc89d20b26f69daaf0933 500000000000000000 7:0 0
# sha256sum /dev/mapper/test
5d16160f9d5f8c33d8051e65fdb4f003cc31cd652b5abb08f03aa6fce0df75fc /dev/mapper/test
Signed-off-by: AliOS system security <alios_sys_security@linux.alibaba.com>
Tested-and-Reviewed-by: Milan Broz <gmazyland@gmail.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Diffstat (limited to 'drivers/bcma/sprom.c')
0 files changed, 0 insertions, 0 deletions