summaryrefslogtreecommitdiffstats
path: root/drivers/bluetooth
diff options
context:
space:
mode:
authorDavid Lechner <david@lechnology.com>2017-12-02 20:43:55 -0600
committerMarcel Holtmann <marcel@holtmann.org>2017-12-13 00:28:41 +0100
commitd54fdcf9244ceca3e2768878b7512f12725437d1 (patch)
tree0ca0f48f306b31a9aa37fbf88db9e9299ea4549d /drivers/bluetooth
parent059fb8230732d101950ae1d435238d78545cf46b (diff)
downloadlinux-d54fdcf9244ceca3e2768878b7512f12725437d1.tar.gz
linux-d54fdcf9244ceca3e2768878b7512f12725437d1.tar.bz2
linux-d54fdcf9244ceca3e2768878b7512f12725437d1.zip
Bluetooth: serdev: hci_ll: Wait for CTS instead of using msleep
When a TI Bluetooth chip is reset, it takes about 100ms for the RTS line of the chip to deassert. For my use case with a TI CC2560A chip, this delay was not long enough and caused the local UART to never transmit at all (TI AM1808 SoC UART2). We can wait for the CTS signal using serdev_device_wait_for_cts() instead of trying to guess using msleep(). Also changed the comment to be more informative while we are touching this code. Signed-off-by: David Lechner <david@lechnology.com> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Diffstat (limited to 'drivers/bluetooth')
-rw-r--r--drivers/bluetooth/hci_ll.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/bluetooth/hci_ll.c b/drivers/bluetooth/hci_ll.c
index ce0dd2f164c7..447abea2fa04 100644
--- a/drivers/bluetooth/hci_ll.c
+++ b/drivers/bluetooth/hci_ll.c
@@ -674,11 +674,15 @@ static int ll_setup(struct hci_uart *hu)
serdev_device_set_flow_control(serdev, true);
do {
- /* Configure BT_EN to HIGH state */
+ /* Reset the Bluetooth device */
gpiod_set_value_cansleep(lldev->enable_gpio, 0);
msleep(5);
gpiod_set_value_cansleep(lldev->enable_gpio, 1);
- msleep(100);
+ err = serdev_device_wait_for_cts(serdev, true, 200);
+ if (err) {
+ bt_dev_err(hu->hdev, "Failed to get CTS");
+ return err;
+ }
err = download_firmware(lldev);
if (!err)