summaryrefslogtreecommitdiffstats
path: root/drivers/crypto/nx
diff options
context:
space:
mode:
authorYang Li <yang.lee@linux.alibaba.com>2021-02-26 09:23:06 +0800
committerHerbert Xu <herbert@gondor.apana.org.au>2021-03-07 15:13:18 +1100
commit1406f0f3440265deec6932fd611549b07ac76e89 (patch)
treed21ee227edcbc11f5998efed928bbfea9db28795 /drivers/crypto/nx
parente40ff6f3eaa25cbf3cbe75d4480802ad1cbb1147 (diff)
downloadlinux-1406f0f3440265deec6932fd611549b07ac76e89.tar.gz
linux-1406f0f3440265deec6932fd611549b07ac76e89.tar.bz2
linux-1406f0f3440265deec6932fd611549b07ac76e89.zip
crypto: nx - add missing call to of_node_put()
In one of the error paths of the for_each_child_of_node() loop, add missing call to of_node_put(). Fix the following coccicheck warning: ./drivers/crypto/nx/nx-common-powernv.c:927:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 936. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto/nx')
-rw-r--r--drivers/crypto/nx/nx-common-powernv.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/crypto/nx/nx-common-powernv.c b/drivers/crypto/nx/nx-common-powernv.c
index 13c65deda8e9..446f611726df 100644
--- a/drivers/crypto/nx/nx-common-powernv.c
+++ b/drivers/crypto/nx/nx-common-powernv.c
@@ -932,8 +932,10 @@ static int __init nx_powernv_probe_vas(struct device_node *pn)
ret = find_nx_device_tree(dn, chip_id, vasid,
NX_CT_GZIP, "ibm,p9-nx-gzip", &ct_gzip);
- if (ret)
+ if (ret) {
+ of_node_put(dn);
return ret;
+ }
}
if (!ct_842 || !ct_gzip) {