diff options
author | Lukas Wunner <lukas@wunner.de> | 2019-12-05 12:54:49 +0100 |
---|---|---|
committer | Vinod Koul <vkoul@kernel.org> | 2019-12-11 16:03:20 +0530 |
commit | 53a256a9b925b47c7e67fc1f16ca41561a7b877c (patch) | |
tree | e822373218a9827e99f46e6d7a9014c670896ef8 /drivers/dma | |
parent | e42617b825f8073569da76dc4510bfa019b1c35a (diff) | |
download | linux-53a256a9b925b47c7e67fc1f16ca41561a7b877c.tar.gz linux-53a256a9b925b47c7e67fc1f16ca41561a7b877c.tar.bz2 linux-53a256a9b925b47c7e67fc1f16ca41561a7b877c.zip |
dmaengine: Fix access to uninitialized dma_slave_caps
dmaengine_desc_set_reuse() allocates a struct dma_slave_caps on the
stack, populates it using dma_get_slave_caps() and then accesses one
of its members.
However dma_get_slave_caps() may fail and this isn't accounted for,
leading to a legitimate warning of gcc-4.9 (but not newer versions):
In file included from drivers/spi/spi-bcm2835.c:19:0:
drivers/spi/spi-bcm2835.c: In function 'dmaengine_desc_set_reuse':
>> include/linux/dmaengine.h:1370:10: warning: 'caps.descriptor_reuse' is used uninitialized in this function [-Wuninitialized]
if (caps.descriptor_reuse) {
Fix it, thereby also silencing the gcc-4.9 warning.
The issue has been present for 4 years but surfaces only now that
the first caller of dmaengine_desc_set_reuse() has been added in
spi-bcm2835.c. Another user of reusable DMA descriptors has existed
for a while in pxa_camera.c, but it sets the DMA_CTRL_REUSE flag
directly instead of calling dmaengine_desc_set_reuse(). Nevertheless,
tag this commit for stable in case there are out-of-tree users.
Fixes: 272420214d26 ("dmaengine: Add DMA_CTRL_REUSE")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Cc: stable@vger.kernel.org # v4.3+
Link: https://lore.kernel.org/r/ca92998ccc054b4f2bfd60ef3adbab2913171eac.1575546234.git.lukas@wunner.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma')
0 files changed, 0 insertions, 0 deletions