diff options
| author | Martin Povišer <povik+lin@cutebit.org> | 2023-02-24 16:22:21 +0100 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2023-03-31 18:17:21 +0530 |
| commit | d9503be5a100c553731c0e8a82c7b4201e8a970c (patch) | |
| tree | 184714a76c1a953cfde483a7516997c959d91cc3 /drivers/dma | |
| parent | 6e96adcaa7a29827ac8ee8df290a44957a4823ec (diff) | |
| download | linux-d9503be5a100c553731c0e8a82c7b4201e8a970c.tar.gz linux-d9503be5a100c553731c0e8a82c7b4201e8a970c.tar.bz2 linux-d9503be5a100c553731c0e8a82c7b4201e8a970c.zip | |
dmaengine: apple-admac: Fix 'current_tx' not getting freed
In terminate_all we should queue up all submitted descriptors to be
freed. We do that for the content of the 'issued' and 'submitted' lists,
but the 'current_tx' descriptor falls through the cracks as it's
removed from the 'issued' list once it gets assigned to be the current
descriptor. Explicitly queue up freeing of the 'current_tx' descriptor
to address a memory leak that is otherwise present.
Fixes: b127315d9a78 ("dmaengine: apple-admac: Add Apple ADMAC driver")
Signed-off-by: Martin Povišer <povik+lin@cutebit.org>
Link: https://lore.kernel.org/r/20230224152222.26732-2-povik+lin@cutebit.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma')
| -rw-r--r-- | drivers/dma/apple-admac.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/dma/apple-admac.c b/drivers/dma/apple-admac.c index b9132b495d18..4cf8da77bdd9 100644 --- a/drivers/dma/apple-admac.c +++ b/drivers/dma/apple-admac.c @@ -512,7 +512,10 @@ static int admac_terminate_all(struct dma_chan *chan) admac_stop_chan(adchan); admac_reset_rings(adchan); - adchan->current_tx = NULL; + if (adchan->current_tx) { + list_add_tail(&adchan->current_tx->node, &adchan->to_free); + adchan->current_tx = NULL; + } /* * Descriptors can only be freed after the tasklet * has been killed (in admac_synchronize). |