diff options
| author | Shiwu Zhang <shiwu.zhang@amd.com> | 2022-11-11 15:54:52 +0800 |
|---|---|---|
| committer | Alex Deucher <alexander.deucher@amd.com> | 2023-06-09 09:48:52 -0400 |
| commit | 37dd9d58a595f4cda5a7f01703592cc4e00f69b4 (patch) | |
| tree | f1ce988e8b5439309207f8515c2b97b52851ac9e /drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | |
| parent | cbd442ce91bdeb8f618511d65e674894a80e4c31 (diff) | |
| download | linux-37dd9d58a595f4cda5a7f01703592cc4e00f69b4.tar.gz linux-37dd9d58a595f4cda5a7f01703592cc4e00f69b4.tar.bz2 linux-37dd9d58a595f4cda5a7f01703592cc4e00f69b4.zip | |
drm/amdgpu: fix kcq mqd_backup buffer double free for multi-XCD
For gfx_v9_4_3 and beyond, struct kiq has its own mqd_backup pointer
rather than using the last pointer from mec struct. Then the kfree
operation on the pointer from the mec struct should be removed otherwise
it will cause double free on the first kcq's mqd_backup buffer on XCD1.
Signed-off-by: Shiwu Zhang <shiwu.zhang@amd.com>
Reviewed-by: Le Ma <le.ma@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c')
| -rw-r--r-- | drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c index c2e92664031b..8aea9e023275 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c @@ -480,7 +480,6 @@ void amdgpu_gfx_mqd_sw_fini(struct amdgpu_device *adev, int xcc_id) ring = &kiq->ring; kfree(kiq->mqd_backup); - kfree(adev->gfx.mec.mqd_backup[AMDGPU_MAX_COMPUTE_RINGS]); amdgpu_bo_free_kernel(&ring->mqd_obj, &ring->mqd_gpu_addr, &ring->mqd_ptr); |