diff options
| author | Jeffrey Hugo <quic_jhugo@quicinc.com> | 2025-02-14 09:21:09 -0700 |
|---|---|---|
| committer | Jeff Hugo <jeff.hugo@oss.qualcomm.com> | 2025-02-21 10:29:28 -0700 |
| commit | acf3256160bdabcb5c07032f3bf6eb5a21f5b95f (patch) | |
| tree | f193f8f6fedd72c4b31c855a7c5027bbcb5f33ea /drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | |
| parent | 27e21f22db9993769b5c983113ccffcac65d772a (diff) | |
| download | linux-acf3256160bdabcb5c07032f3bf6eb5a21f5b95f.tar.gz linux-acf3256160bdabcb5c07032f3bf6eb5a21f5b95f.tar.bz2 linux-acf3256160bdabcb5c07032f3bf6eb5a21f5b95f.zip | |
bus: mhi: host: Avoid possible uninitialized fw_load_type
If mhi_fw_load_handler() bails out early because the EE is not capable
of loading firmware, we may reference fw_load_type in cleanup which is
uninitialized at this point. The cleanup code checks fw_load_type as a
proxy for knowing if fbc_image was allocated and needs to be freed, but
we can directly test for that. This avoids the possible uninitialized
access and appears to be clearer code.
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/e3148ac4-7bb8-422d-ae0f-18a8eb15e269@stanley.mountain/
Fixes: f88f1d0998ea ("bus: mhi: host: Add a policy to enable image transfer via BHIe in PBL")
Signed-off-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: Carl Vanderlip <quic_carlv@quicinc.com>
Signed-off-by: Jeff Hugo <jeff.hugo@oss.qualcomm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250214162109.3555300-1-quic_jhugo@quicinc.com
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_job.c')
0 files changed, 0 insertions, 0 deletions