summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/amd/display/dc/clk_mgr
diff options
context:
space:
mode:
authorIvan Lipski <ivlipski@amd.com>2024-05-27 13:28:44 -0400
committerAlex Deucher <alexander.deucher@amd.com>2024-06-14 16:17:15 -0400
commit0eea12b9bdd5f917c3fb00c5ef710398f7c7bfac (patch)
treea4410bef5ca705cb8f6671780fcc4872f39398f0 /drivers/gpu/drm/amd/display/dc/clk_mgr
parent1b51220dc28cd34f80467acaff60294348cf6675 (diff)
downloadlinux-0eea12b9bdd5f917c3fb00c5ef710398f7c7bfac.tar.gz
linux-0eea12b9bdd5f917c3fb00c5ef710398f7c7bfac.tar.bz2
linux-0eea12b9bdd5f917c3fb00c5ef710398f7c7bfac.zip
drm/amd/display: Remove duplicate 'update_idle_uclk' in dcn401 clk_mgr code
[WHY] The coverity analysis flagged this if expression as it contains a 'CONSTANT_EXPRESSION_RESULT': 'update_idle_uclk' is 'ORd' with itself. [HOW] Removed the duplicate 'update_idle_uclk'. Reviewed-by: Alex Hung <alex.hung@amd.com> Acked-by: Zaeem Mohamed <zaeem.mohamed@amd.com> Signed-off-by: Ivan Lipski <ivlipski@amd.com> Tested-by: Daniel Wheeler <daniel.wheeler@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers/gpu/drm/amd/display/dc/clk_mgr')
-rw-r--r--drivers/gpu/drm/amd/display/dc/clk_mgr/dcn401/dcn401_clk_mgr.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn401/dcn401_clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn401/dcn401_clk_mgr.c
index 0fbe615069f0..28769deaad37 100644
--- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn401/dcn401_clk_mgr.c
+++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn401/dcn401_clk_mgr.c
@@ -940,7 +940,7 @@ static unsigned int dcn401_build_update_bandwidth_clocks_sequence(
}
/* CLK_MGR401_UPDATE_IDLE_HARDMINS */
- if ((update_idle_uclk || update_idle_uclk) && is_idle_dpm_enabled) {
+ if (update_idle_uclk && is_idle_dpm_enabled) {
block_sequence[num_steps].params.update_idle_hardmin_params.uclk_mhz = idle_uclk_mhz;
block_sequence[num_steps].params.update_idle_hardmin_params.fclk_mhz = idle_fclk_mhz;
block_sequence[num_steps].func = CLK_MGR401_UPDATE_IDLE_HARDMINS;