diff options
| author | Michel Dänzer <mdaenzer@redhat.com> | 2020-09-04 12:43:04 +0200 |
|---|---|---|
| committer | Alex Deucher <alexander.deucher@amd.com> | 2020-09-15 17:52:43 -0400 |
| commit | b836a274b797e90ff0b3bccf0a1e6f8557f590bb (patch) | |
| tree | 042558a3bc6b26d1567caae933a0684a30b4075f /drivers/gpu/drm/amd/pm/inc/amdgpu_smu.h | |
| parent | f4075be88246eeb9b6cf50339fd6ebf9201f2091 (diff) | |
| download | linux-b836a274b797e90ff0b3bccf0a1e6f8557f590bb.tar.gz linux-b836a274b797e90ff0b3bccf0a1e6f8557f590bb.tar.bz2 linux-b836a274b797e90ff0b3bccf0a1e6f8557f590bb.zip | |
drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is
Don't check drm_crtc_state::active for this either, per its
documentation in include/drm/drm_crtc.h:
* Hence drivers must not consult @active in their various
* &drm_mode_config_funcs.atomic_check callback to reject an atomic
* commit.
atomic_remove_fb disables the CRTC as needed for disabling the primary
plane.
This prevents at least the following problems if the primary plane gets
disabled (e.g. due to destroying the FB assigned to the primary plane,
as happens e.g. with mutter in Wayland mode):
* The legacy cursor ioctl returned EINVAL for a non-0 cursor FB ID
(which enables the cursor plane).
* If the cursor plane was enabled, changing the legacy DPMS property
value from off to on returned EINVAL.
v2:
* Minor changes to code comment and commit log, per review feedback.
GitLab: https://gitlab.gnome.org/GNOME/mutter/-/issues/1108
GitLab: https://gitlab.gnome.org/GNOME/mutter/-/issues/1165
GitLab: https://gitlab.gnome.org/GNOME/mutter/-/issues/1344
Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Michel Dänzer <mdaenzer@redhat.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers/gpu/drm/amd/pm/inc/amdgpu_smu.h')
0 files changed, 0 insertions, 0 deletions