diff options
| author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2014-04-05 10:09:36 +0200 |
|---|---|---|
| committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2014-04-22 15:39:06 +0200 |
| commit | 275c63222761255e5a34eac8327ea65a10fdd8d4 (patch) | |
| tree | c9cdab974c0843e0d53b0f2342b308affd0b183f /drivers/gpu/drm/cirrus | |
| parent | 4cb8802e28c14a4b34827154ab1537bbde796cc2 (diff) | |
| download | linux-275c63222761255e5a34eac8327ea65a10fdd8d4.tar.gz linux-275c63222761255e5a34eac8327ea65a10fdd8d4.tar.bz2 linux-275c63222761255e5a34eac8327ea65a10fdd8d4.zip | |
drm/cirrus: Remove unnecessary NULL check in bo_unref
ttm_bo_unref unconditionally calls kref_put on it's argument, so the
thing can't be NULL without already causing Oopses.
Spotted by coverity.
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu/drm/cirrus')
| -rw-r--r-- | drivers/gpu/drm/cirrus/cirrus_main.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/gpu/drm/cirrus/cirrus_main.c b/drivers/gpu/drm/cirrus/cirrus_main.c index 4b0170cf53fd..b119f66fed92 100644 --- a/drivers/gpu/drm/cirrus/cirrus_main.c +++ b/drivers/gpu/drm/cirrus/cirrus_main.c @@ -264,9 +264,7 @@ static void cirrus_bo_unref(struct cirrus_bo **bo) tbo = &((*bo)->bo); ttm_bo_unref(&tbo); - if (tbo == NULL) - *bo = NULL; - + *bo = NULL; } void cirrus_gem_free_object(struct drm_gem_object *obj) |