diff options
| author | Colin Ian King <colin.king@canonical.com> | 2021-06-18 19:35:24 +0100 |
|---|---|---|
| committer | Patrik Jakobsson <patrik.r.jakobsson@gmail.com> | 2021-06-18 21:17:20 +0200 |
| commit | e87138e05c803a78460a6b59fa75a05f92aa80fb (patch) | |
| tree | 625afd009ddb2b7facad40691c5bc5a9dd1ff6d7 /drivers/gpu/drm/gma500/oaktrail_lvds.c | |
| parent | 12fc23a4a3d1dbeaf609c1f27af59755d48cb0fb (diff) | |
| download | linux-e87138e05c803a78460a6b59fa75a05f92aa80fb.tar.gz linux-e87138e05c803a78460a6b59fa75a05f92aa80fb.tar.bz2 linux-e87138e05c803a78460a6b59fa75a05f92aa80fb.zip | |
drm/gma500/oaktrail_lvds: replace continue with break
Currently a loop scans through the connector list checking
for connectors that do not match a specific criteria. The
use of the continue statement is a little unintuitive and
can confuse static analysis checking. Invert the criteria
matching logic and use a break to terminate the loop once
the first suitable connector has been found.
Thanks to Patrik Jakobsson for explaining the original
intent of the code and suggesting this change.
Addresses-Coverity: ("Continue has no effect")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210618183524.590186-1-colin.king@canonical.com
Diffstat (limited to 'drivers/gpu/drm/gma500/oaktrail_lvds.c')
| -rw-r--r-- | drivers/gpu/drm/gma500/oaktrail_lvds.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/gma500/oaktrail_lvds.c b/drivers/gpu/drm/gma500/oaktrail_lvds.c index 432bdcc57ac9..1f2f892961d6 100644 --- a/drivers/gpu/drm/gma500/oaktrail_lvds.c +++ b/drivers/gpu/drm/gma500/oaktrail_lvds.c @@ -113,8 +113,8 @@ static void oaktrail_lvds_mode_set(struct drm_encoder *encoder, /* Find the connector we're trying to set up */ list_for_each_entry(connector, &mode_config->connector_list, head) { - if (!connector->encoder || connector->encoder->crtc != crtc) - continue; + if (connector->encoder && connector->encoder->crtc == crtc) + break; } if (!connector) { |