summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/i915/display/intel_fb_pin.c
diff options
context:
space:
mode:
authorMatthew Auld <matthew.auld@intel.com>2022-10-04 14:19:12 +0100
committerMatthew Auld <matthew.auld@intel.com>2022-10-05 09:01:49 +0100
commit3bce981f58421a0a111f04f594ad654afff9f95c (patch)
tree7b67eaf8ce5fc4525b20daf2a390e6b800adca8f /drivers/gpu/drm/i915/display/intel_fb_pin.c
parent0add082cebac8555ee3972ba768ae5c01db7a498 (diff)
downloadlinux-3bce981f58421a0a111f04f594ad654afff9f95c.tar.gz
linux-3bce981f58421a0a111f04f594ad654afff9f95c.tar.bz2
linux-3bce981f58421a0a111f04f594ad654afff9f95c.zip
drm/i915: remove the TODO in pin_and_fence_fb_obj
The copy is async (if there even is one), but when later updating the GGTT we always sync against the binding, which will in turn sync against any moves. Signed-off-by: Matthew Auld <matthew.auld@intel.com> Cc: Jianshui Yu <jianshui.yu@intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Nirmoy Das <nirmoy.das@intel.com> Reviewed-by: Nirmoy Das <nirmoy.das@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20221004131916.233474-1-matthew.auld@intel.com
Diffstat (limited to 'drivers/gpu/drm/i915/display/intel_fb_pin.c')
-rw-r--r--drivers/gpu/drm/i915/display/intel_fb_pin.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/display/intel_fb_pin.c b/drivers/gpu/drm/i915/display/intel_fb_pin.c
index c86e5d4ee016..0cd9e8cb078b 100644
--- a/drivers/gpu/drm/i915/display/intel_fb_pin.c
+++ b/drivers/gpu/drm/i915/display/intel_fb_pin.c
@@ -141,7 +141,6 @@ retry:
ret = i915_gem_object_attach_phys(obj, alignment);
else if (!ret && HAS_LMEM(dev_priv))
ret = i915_gem_object_migrate(obj, &ww, INTEL_REGION_LMEM_0);
- /* TODO: Do we need to sync when migration becomes async? */
if (!ret)
ret = i915_gem_object_pin_pages(obj);
if (ret)