diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2022-04-25 21:23:06 +0200 |
|---|---|---|
| committer | Javier Martinez Canillas <javierm@redhat.com> | 2022-04-26 09:43:37 +0200 |
| commit | a4359b4e479bfa947a20a1ac5d406dae654f8a54 (patch) | |
| tree | 2745b6dfccfcb4fa60f5c9c9fa93f54070dbfc82 /drivers/gpu/drm/solomon | |
| parent | 57e6f0562cb40d54dbe030f94c6307665b69a594 (diff) | |
| download | linux-a4359b4e479bfa947a20a1ac5d406dae654f8a54.tar.gz linux-a4359b4e479bfa947a20a1ac5d406dae654f8a54.tar.bz2 linux-a4359b4e479bfa947a20a1ac5d406dae654f8a54.zip | |
drm/ssd130x: Make ssd130x_remove() return void
This function returns zero unconditionally, so there isn't any benefit
of returning a value. Make it return void to be able to see at a glance
that the return value of ssd130x_i2c_remove() is always zero.
This patch is a preparation for making i2c remove callbacks return void.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Javier Martinez Canillas <javierm@redhat.com>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220425192306.59800-1-u.kleine-koenig@pengutronix.de
Diffstat (limited to 'drivers/gpu/drm/solomon')
| -rw-r--r-- | drivers/gpu/drm/solomon/ssd130x-i2c.c | 4 | ||||
| -rw-r--r-- | drivers/gpu/drm/solomon/ssd130x.c | 4 | ||||
| -rw-r--r-- | drivers/gpu/drm/solomon/ssd130x.h | 2 |
3 files changed, 5 insertions, 5 deletions
diff --git a/drivers/gpu/drm/solomon/ssd130x-i2c.c b/drivers/gpu/drm/solomon/ssd130x-i2c.c index d6835ec71c39..1e0fcec7be47 100644 --- a/drivers/gpu/drm/solomon/ssd130x-i2c.c +++ b/drivers/gpu/drm/solomon/ssd130x-i2c.c @@ -43,7 +43,9 @@ static int ssd130x_i2c_remove(struct i2c_client *client) { struct ssd130x_device *ssd130x = i2c_get_clientdata(client); - return ssd130x_remove(ssd130x); + ssd130x_remove(ssd130x); + + return 0; } static void ssd130x_i2c_shutdown(struct i2c_client *client) diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ssd130x.c index ba2de93d00f0..08394444dd6e 100644 --- a/drivers/gpu/drm/solomon/ssd130x.c +++ b/drivers/gpu/drm/solomon/ssd130x.c @@ -924,11 +924,9 @@ struct ssd130x_device *ssd130x_probe(struct device *dev, struct regmap *regmap) } EXPORT_SYMBOL_GPL(ssd130x_probe); -int ssd130x_remove(struct ssd130x_device *ssd130x) +void ssd130x_remove(struct ssd130x_device *ssd130x) { drm_dev_unplug(&ssd130x->drm); - - return 0; } EXPORT_SYMBOL_GPL(ssd130x_remove); diff --git a/drivers/gpu/drm/solomon/ssd130x.h b/drivers/gpu/drm/solomon/ssd130x.h index d14f78c2eb07..4c4a84e962e7 100644 --- a/drivers/gpu/drm/solomon/ssd130x.h +++ b/drivers/gpu/drm/solomon/ssd130x.h @@ -86,7 +86,7 @@ struct ssd130x_device { extern const struct ssd130x_deviceinfo ssd130x_variants[]; struct ssd130x_device *ssd130x_probe(struct device *dev, struct regmap *regmap); -int ssd130x_remove(struct ssd130x_device *ssd130x); +void ssd130x_remove(struct ssd130x_device *ssd130x); void ssd130x_shutdown(struct ssd130x_device *ssd130x); #endif /* __SSD1307X_H__ */ |