summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm
diff options
context:
space:
mode:
authorDouglas Anderson <dianders@chromium.org>2024-03-19 13:58:39 -0700
committerDouglas Anderson <dianders@chromium.org>2024-03-26 08:58:53 -0700
commit6376eb8b911534735fec104c1a0d780e4cf3116a (patch)
tree3984f76ec24d7941683888f58c7a824d86136d9b /drivers/gpu/drm
parent9d1848778e56fb565db041e4237a2f27f9277f63 (diff)
downloadlinux-6376eb8b911534735fec104c1a0d780e4cf3116a.tar.gz
linux-6376eb8b911534735fec104c1a0d780e4cf3116a.tar.bz2
linux-6376eb8b911534735fec104c1a0d780e4cf3116a.zip
drm/dp: Clarify that wait_hpd_asserted() is not optional for panels
In response to my patch removing the "wait for HPD" logic at the beginning of the MSM DP transfer() callback [1], we had some debate about what the "This is an optional function" meant in the documentation of the wait_hpd_asserted() callback. Let's clarify. As talked about in the MSM DP patch [1], before wait_hpd_asserted() was introduced there was no great way for panel drivers to wait for HPD in the case that the "built-in" HPD signal was used. Panel drivers could only wait for HPD if a GPIO was used. At the time, we ended up just saying that if we were using the "built-in" HPD signal that DP AUX controllers needed to wait for HPD themselves at the beginning of their transfer() callback. The fact that the wait for HPD at the beginning of transfer() was awkward/problematic was the whole reason wait_hpd_asserted() was added. Let's make it obvious that if a DP AUX controller implements wait_hpd_asserted() that they don't need a loop waiting for HPD at the start of their transfer() function. We'll still allow DP controllers to work the old way but mark it as deprecated. [1] https://lore.kernel.org/r/20240315143621.v2.3.I535606f6d4f7e3e5588bb75c55996f61980183cd@changeid Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Signed-off-by: Douglas Anderson <dianders@chromium.org> Link: https://patchwork.freedesktop.org/patch/msgid/20240319135836.v2.1.I521dad0693cc24fe4dd14cba0c7048d94f5b6b41@changeid
Diffstat (limited to 'drivers/gpu/drm')
0 files changed, 0 insertions, 0 deletions