diff options
author | Vincent Mailhol <mailhol.vincent@wanadoo.fr> | 2022-03-17 12:55:06 +0900 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-04-23 10:33:53 +0200 |
commit | 0f08c2e7458e25c967d844170f8ad1aac3b57a02 (patch) | |
tree | 611a9a2e6cad06472d3257b14e00a50edc26176b /drivers/hid/hid-keytouch.c | |
parent | 63acaa8e9c65dc34dc249440216f8e977f5d2748 (diff) | |
download | linux-0f08c2e7458e25c967d844170f8ad1aac3b57a02.tar.gz linux-0f08c2e7458e25c967d844170f8ad1aac3b57a02.tar.bz2 linux-0f08c2e7458e25c967d844170f8ad1aac3b57a02.zip |
usb: deprecate the third argument of usb_maxpacket()
This is a transitional patch with the ultimate goal of changing the
prototype of usb_maxpacket() from:
| static inline __u16
| usb_maxpacket(struct usb_device *udev, int pipe, int is_out)
into:
| static inline u16 usb_maxpacket(struct usb_device *udev, int pipe)
The third argument of usb_maxpacket(): is_out gets removed because it
can be derived from its second argument: pipe using
usb_pipeout(pipe). Furthermore, in the current version,
ubs_pipeout(pipe) is called regardless in order to sanitize the is_out
parameter.
In order to make a smooth change, we first deprecate the is_out
parameter by simply ignoring it (using a variadic function) and will
remove it later, once all the callers get updated.
The body of the function is reworked accordingly and is_out is
replaced by usb_pipeout(pipe). The WARN_ON() calls become unnecessary
and get removed.
Finally, the return type is changed from __u16 to u16 because this is
not a UAPI function.
Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Link: https://lore.kernel.org/r/20220317035514.6378-2-mailhol.vincent@wanadoo.fr
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/hid/hid-keytouch.c')
0 files changed, 0 insertions, 0 deletions