diff options
| author | Aditya Pakki <pakki001@umn.edu> | 2018-12-24 15:39:14 -0600 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.cz> | 2019-01-03 11:30:08 +0100 |
| commit | 6ae16dfb61bce538d48b7fe98160fada446056c5 (patch) | |
| tree | 43618cb1ec00965494db6c883ba7645d512399e0 /drivers/hid | |
| parent | 46b14eef59a8157138dc02f916a7f97c73b3ec53 (diff) | |
| download | linux-6ae16dfb61bce538d48b7fe98160fada446056c5.tar.gz linux-6ae16dfb61bce538d48b7fe98160fada446056c5.tar.bz2 linux-6ae16dfb61bce538d48b7fe98160fada446056c5.zip | |
HID: lenovo: Add checks to fix of_led_classdev_register
In lenovo_probe_tpkbd(), the function of_led_classdev_register() could
return an error value that is unchecked. The fix adds these checks.
Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid')
| -rw-r--r-- | drivers/hid/hid-lenovo.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c index 643b6eb54442..eacc76d2ab96 100644 --- a/drivers/hid/hid-lenovo.c +++ b/drivers/hid/hid-lenovo.c @@ -743,7 +743,9 @@ static int lenovo_probe_tpkbd(struct hid_device *hdev) data_pointer->led_mute.brightness_get = lenovo_led_brightness_get_tpkbd; data_pointer->led_mute.brightness_set = lenovo_led_brightness_set_tpkbd; data_pointer->led_mute.dev = dev; - led_classdev_register(dev, &data_pointer->led_mute); + ret = led_classdev_register(dev, &data_pointer->led_mute); + if (ret < 0) + goto err; data_pointer->led_micmute.name = name_micmute; data_pointer->led_micmute.brightness_get = @@ -751,7 +753,11 @@ static int lenovo_probe_tpkbd(struct hid_device *hdev) data_pointer->led_micmute.brightness_set = lenovo_led_brightness_set_tpkbd; data_pointer->led_micmute.dev = dev; - led_classdev_register(dev, &data_pointer->led_micmute); + ret = led_classdev_register(dev, &data_pointer->led_micmute); + if (ret < 0) { + led_classdev_unregister(&data_pointer->led_mute); + goto err; + } lenovo_features_set_tpkbd(hdev); |