diff options
| author | Zhang Qilong <zhangqilong3@huawei.com> | 2020-11-23 18:18:27 +0800 |
|---|---|---|
| committer | Sebastian Reichel <sre@kernel.org> | 2020-12-29 23:57:06 +0100 |
| commit | aa57e77b3d28f0df07149d88c47bc0f3aa77330b (patch) | |
| tree | ff5c576bff59904d8776236d95fe267e35e82144 /drivers/hsi | |
| parent | 5c8fe583cce542aa0b84adc939ce85293de36e5e (diff) | |
| download | linux-aa57e77b3d28f0df07149d88c47bc0f3aa77330b.tar.gz linux-aa57e77b3d28f0df07149d88c47bc0f3aa77330b.tar.bz2 linux-aa57e77b3d28f0df07149d88c47bc0f3aa77330b.zip | |
HSI: Fix PM usage counter unbalance in ssi_hw_init
pm_runtime_get_sync will increment pm usage counter
even it failed. Forgetting to putting operation will
result in reference leak here. We fix it by replacing
it with pm_runtime_resume_and_get to keep usage counter
balanced.
Fixes: b209e047bc743 ("HSI: Introduce OMAP SSI driver")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
Diffstat (limited to 'drivers/hsi')
| -rw-r--r-- | drivers/hsi/controllers/omap_ssi_core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hsi/controllers/omap_ssi_core.c b/drivers/hsi/controllers/omap_ssi_core.c index 7596dc164648..44a3f5660c10 100644 --- a/drivers/hsi/controllers/omap_ssi_core.c +++ b/drivers/hsi/controllers/omap_ssi_core.c @@ -424,7 +424,7 @@ static int ssi_hw_init(struct hsi_controller *ssi) struct omap_ssi_controller *omap_ssi = hsi_controller_drvdata(ssi); int err; - err = pm_runtime_get_sync(ssi->device.parent); + err = pm_runtime_resume_and_get(ssi->device.parent); if (err < 0) { dev_err(&ssi->device, "runtime PM failed %d\n", err); return err; |