summaryrefslogtreecommitdiffstats
path: root/drivers/hwmon/nct6775.c
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2018-09-05 10:46:27 +0300
committerGuenter Roeck <linux@roeck-us.net>2018-09-05 14:47:50 -0700
commite3f3d7ab00cd459d0f7a839758a4542f4d4b8ac8 (patch)
treeb6bc22f3467df9d9ca24e84a59cc2df934b898fe /drivers/hwmon/nct6775.c
parent57361846b52bc686112da6ca5368d11210796804 (diff)
downloadlinux-e3f3d7ab00cd459d0f7a839758a4542f4d4b8ac8.tar.gz
linux-e3f3d7ab00cd459d0f7a839758a4542f4d4b8ac8.tar.bz2
linux-e3f3d7ab00cd459d0f7a839758a4542f4d4b8ac8.zip
hwmon: (nct6775) Set weight source to zero correctly
This is dead code because j can never be 1 at this point. We had intended to just test if the bit was clear. Fixes: bbd8decd4123 ("hwmon: (nct6775) Add support for weighted fan control") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon/nct6775.c')
-rw-r--r--drivers/hwmon/nct6775.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c
index 944f5b63aecd..139781ae830b 100644
--- a/drivers/hwmon/nct6775.c
+++ b/drivers/hwmon/nct6775.c
@@ -1558,7 +1558,7 @@ static void nct6775_update_pwm(struct device *dev)
reg = nct6775_read_value(data, data->REG_WEIGHT_TEMP_SEL[i]);
data->pwm_weight_temp_sel[i] = reg & 0x1f;
/* If weight is disabled, report weight source as 0 */
- if (j == 1 && !(reg & 0x80))
+ if (!(reg & 0x80))
data->pwm_weight_temp_sel[i] = 0;
/* Weight temp data */