diff options
| author | Julia Lawall <Julia.Lawall@lip6.fr> | 2016-12-22 13:04:58 +0100 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2017-01-02 10:19:45 -0800 |
| commit | a93c843bbfbd1a010adcd9bc156b0362edabc0d2 (patch) | |
| tree | 654b7e568c6bdc5fd55b6c140d2eb78e52b2e913 /drivers/hwmon | |
| parent | 23eb359dd62224d971d0c70d11f57822560ce323 (diff) | |
| download | linux-a93c843bbfbd1a010adcd9bc156b0362edabc0d2.tar.gz linux-a93c843bbfbd1a010adcd9bc156b0362edabc0d2.tar.bz2 linux-a93c843bbfbd1a010adcd9bc156b0362edabc0d2.zip | |
hwmon: (max197) use permission-specific DEVICE_ATTR variants
Use DEVICE_ATTR_RO for read-only attributes. This simplifies the source
code, improves readbility, and reduces the chance of inconsistencies.
The conversion was done automatically using coccinelle. It was validated
by compiling both the old and the new source code and comparing its text,
data, and bss size.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
[groeck: Updated description]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon')
| -rw-r--r-- | drivers/hwmon/max197.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/hwmon/max197.c b/drivers/hwmon/max197.c index 07628569547a..638567fb7cd8 100644 --- a/drivers/hwmon/max197.c +++ b/drivers/hwmon/max197.c @@ -207,8 +207,8 @@ unlock: return ret; } -static ssize_t max197_show_name(struct device *dev, - struct device_attribute *attr, char *buf) +static ssize_t name_show(struct device *dev, struct device_attribute *attr, + char *buf) { struct platform_device *pdev = to_platform_device(dev); return sprintf(buf, "%s\n", pdev->name); @@ -231,7 +231,7 @@ static ssize_t max197_show_name(struct device *dev, &sensor_dev_attr_in##chan##_max.dev_attr.attr, \ &sensor_dev_attr_in##chan##_min.dev_attr.attr -static DEVICE_ATTR(name, S_IRUGO, max197_show_name, NULL); +static DEVICE_ATTR_RO(name); MAX197_SENSOR_DEVICE_ATTR_CH(0); MAX197_SENSOR_DEVICE_ATTR_CH(1); |