diff options
| author | Vasileios Amoiridis <vassilisamir@gmail.com> | 2024-05-08 17:54:07 +0200 |
|---|---|---|
| committer | Jonathan Cameron <Jonathan.Cameron@huawei.com> | 2024-05-27 09:49:20 +0100 |
| commit | bedb2ccb566de5ca0c336ca3fd3588cea6d50414 (patch) | |
| tree | bde6ee3aa605568dbab95da649d2ab3a3e8937c0 /drivers/iio/imu/bmi323 | |
| parent | 279428df888319bf68f2686934897301a250bb84 (diff) | |
| download | linux-bedb2ccb566de5ca0c336ca3fd3588cea6d50414.tar.gz linux-bedb2ccb566de5ca0c336ca3fd3588cea6d50414.tar.bz2 linux-bedb2ccb566de5ca0c336ca3fd3588cea6d50414.zip | |
iio: imu: bmi323: Fix trigger notification in case of error
In case of error in the bmi323_trigger_handler() function, the
function exits without calling the iio_trigger_notify_done()
which is responsible for informing the attached trigger that
the process is done and in case there is a .reenable(), to
call it.
Fixes: 8a636db3aa57 ("iio: imu: Add driver for BMI323 IMU")
Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
Link: https://lore.kernel.org/r/20240508155407.139805-1-vassilisamir@gmail.com
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Diffstat (limited to 'drivers/iio/imu/bmi323')
| -rw-r--r-- | drivers/iio/imu/bmi323/bmi323_core.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/iio/imu/bmi323/bmi323_core.c b/drivers/iio/imu/bmi323/bmi323_core.c index 5d42ab9b176a..67d74a1a1b26 100644 --- a/drivers/iio/imu/bmi323/bmi323_core.c +++ b/drivers/iio/imu/bmi323/bmi323_core.c @@ -1391,7 +1391,7 @@ static irqreturn_t bmi323_trigger_handler(int irq, void *p) &data->buffer.channels, ARRAY_SIZE(data->buffer.channels)); if (ret) - return IRQ_NONE; + goto out; } else { for_each_set_bit(bit, indio_dev->active_scan_mask, BMI323_CHAN_MAX) { @@ -1400,13 +1400,14 @@ static irqreturn_t bmi323_trigger_handler(int irq, void *p) &data->buffer.channels[index++], BMI323_BYTES_PER_SAMPLE); if (ret) - return IRQ_NONE; + goto out; } } iio_push_to_buffers_with_timestamp(indio_dev, &data->buffer, iio_get_time_ns(indio_dev)); +out: iio_trigger_notify_done(indio_dev->trig); return IRQ_HANDLED; |