summaryrefslogtreecommitdiffstats
path: root/drivers/iio
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2012-09-19 07:27:00 +0100
committerJonathan Cameron <jic23@kernel.org>2012-09-22 10:09:40 +0100
commit369d0e20138c774e4c0c07ca1572e412207bc3fc (patch)
treefc66e7e7c68d529e64be8ac5c16ad0fda0f3d430 /drivers/iio
parentf07b60b7c34b771431f1d00e783f29a3667ff5ee (diff)
downloadlinux-369d0e20138c774e4c0c07ca1572e412207bc3fc.tar.gz
linux-369d0e20138c774e4c0c07ca1572e412207bc3fc.tar.bz2
linux-369d0e20138c774e4c0c07ca1572e412207bc3fc.zip
iio: dac/ad5755: signedness bug in ad5755_setup_pdata()
We need "ret" to be signed for the error handling to work correctly. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Lars-Peter Clausen <lars@metafoo.de> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Diffstat (limited to 'drivers/iio')
-rw-r--r--drivers/iio/dac/ad5755.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c
index e6dbe5ff7e5a..5db3506034c5 100644
--- a/drivers/iio/dac/ad5755.c
+++ b/drivers/iio/dac/ad5755.c
@@ -451,9 +451,9 @@ static int __devinit ad5755_setup_pdata(struct iio_dev *indio_dev,
const struct ad5755_platform_data *pdata)
{
struct ad5755_state *st = iio_priv(indio_dev);
- unsigned int ret;
unsigned int val;
unsigned int i;
+ int ret;
if (pdata->dc_dc_phase > AD5755_DC_DC_PHASE_90_DEGREE ||
pdata->dc_dc_freq > AD5755_DC_DC_FREQ_650kHZ ||